feat: new message type PURCHASE_NOTIFICATION#1226
Draft
EmmmaTech wants to merge 2 commits intoDisnakeDev:masterfrom
Draft
feat: new message type PURCHASE_NOTIFICATION#1226EmmmaTech wants to merge 2 commits intoDisnakeDev:masterfrom
EmmmaTech wants to merge 2 commits intoDisnakeDev:masterfrom
Conversation
Snipy7374
reviewed
Aug 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements GH-1225 & relevant types from the OpenAPI spec:
Message.purchase_notification&PurchaseNotification.Since these data types are not officially documented yet, I will put this PR on draft.
(Note: I am aware that attributes specified in the OpenAPI spec are technically public for anyone to implement, however I do not feel comfortable having the PR merged now without any explicit docs outlining this feature.)
Checklist
pdm lintpdm pyright