ENG-1469: Refactor getDiscourseRelations and getDiscourseNodes to read from block props

[sid597]

https://www.loom.com/share/c2ec64fca234492d9a0cd15f7a44a067

---

Summary by CodeRabbit

• New Features

  • Extended conditional logic system with new "not or" operator for more complex condition combinations.

• Refactoring

  • Restructured internal data handling for discourse nodes and relations to align with updated system architecture.

[linear]

ENG-1469 Refactor getDiscourseRelations and getDiscourseNodes to read from block props

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR implements a feature-flagged migration of discourse nodes and relations retrieval from legacy configuration to a new settings-store-backed approach. The accessors are refactored to transform settings data into standardized DiscourseNode and DiscourseRelation types, the Condition type is exported publicly with a new "not or" variant, and consumer functions conditionally route to the new store or preserve existing behavior.

Changes

Cohort / File(s)	Summary
Type definitions and transformations apps/roam/src/components/settings/utils/zodSchema.ts, apps/roam/src/components/settings/utils/accessors.ts	Extended Condition type to include "not or" variant; refactored getAllDiscourseNodes() and getAllRelations() with new transformers (toDiscourseNode, addConditionUids) to normalize settings data into DiscourseNode[] and DiscourseRelation[] structures; updated return types and type imports.
Feature-flagged consumers apps/roam/src/utils/getDiscourseNodes.ts, apps/roam/src/utils/getDiscourseRelations.ts	Introduced conditional logic using isNewSettingsStoreEnabled() to route node/relation retrieval to new settings-store accessors or preserve legacy behavior; maintains existing fallback and configuration patterns.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• ENG-1187: Prod: Implement get and set for block prop based settings #669: Introduced the original getAllDiscourseNodes/getAllRelations accessor functions that this PR refactors with new transformers and updated return types.
• ENG-1328: Port small blueprint based misc settings into props based #805: Consumes and extends the updated DiscourseNode/DiscourseRelation types and Condition schema exported by this PR.
• ENG-1290: Port discourse node config panel #769: Related updates to how discourse relations and ifConditions are persisted and structured in the settings store that these accessors adapt to.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main refactoring work: changing getDiscourseRelations and getDiscourseNodes to read from block props via the new settings store.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.