Skip to content

Fixes "FormatString not working with custom texts", "Control not scaling correctly with HorizontalAlignment set to 'Stretch'" #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 22, 2022

Conversation

jholzer
Copy link
Contributor

@jholzer jholzer commented Oct 27, 2022

Fix #1: FormatString not working with custom texts

  • do not put format string into "format-string-like" curly brackets if if allready looks like a format string
  • Consolidate Format string handling in base class
  • adapt demo application

Fix #2: Control not scaling correctly with HorizontalAlignment set to "Stretch"

  • control´s grid columns were set to auto and Horizontal allignment was set to "Center". TextBlocks were set to "Left"-Alignment. This prevents control to scale correctly in "Stretch"-mode. Buttons must be right-allgined for correct scaling
  • extend demo app with GridSplitters, so that scaling can be validated

FormatException was fixed in Demo tool

Regarding to Microsoft documentation format string "D" is only supported by integral types (sbyte , byte , short , ushort , int , uint , long , ulong , and char)
(see https://learn.microsoft.com/en-us/dotnet/standard/base-types/standard-numeric-format-strings)
So a different Format string must be provided here in demo tool.

Jürgen Holzer and others added 8 commits October 27, 2022 13:27
Regarding to Microsoft documentation format string "D" is only supported by intragral types (sbyte , byte , short , ushort , int , uint , long , ulong , and char)
(see https://learn.microsoft.com/en-us/dotnet/standard/base-types/standard-numeric-format-strings)
So a different Format string must be provided here in demo tool.
…ke a valid format string

Allow editing of format string in demo UI
…ith HorizontanAlignment set to "Stretch"

Adapted Demo-Application
@Dirkster99 Dirkster99 merged commit 80f153b into Dirkster99:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increment , decrement with mouse drag Feature Request: Adding a step size
2 participants