- 
                Notifications
    You must be signed in to change notification settings 
- Fork 153
          Introduce a Units trait
          #855
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| type Calc: Calc; | ||
| } | ||
|  | ||
| /// A default implementation of the [`Units`] trait | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should note that it has no specific semantic value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "semantic value"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. I think the semantics are clearer and I don't mind the added generics.
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Objective
Introduce an abstraction that allows "the whole of Taffy" to be generic over multiple types with only one generic parameter.
The core of this change is the introduction of:
Context
Stylestruct) generic over a string typeCalctype.Feedback wanted
Is this a sensible change or am I going overboard with the generic types?