From be8c2a52f2b1d8d30ff900ee637420d36b357c3b Mon Sep 17 00:00:00 2001 From: Doug Roeper Date: Mon, 10 Jan 2022 22:05:50 -0500 Subject: [PATCH] Remove types not part of THREE namespace Fixes https://github.com/pmndrs/drei/issues/704 --- package.json | 2 +- packages/fiber/src/three-types.ts | 11 ----------- yarn.lock | 8 ++++---- 3 files changed, 5 insertions(+), 16 deletions(-) diff --git a/package.json b/package.json index 7d2bfb4074..99c1cb659a 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "@types/react-reconciler": "^0.26.2", "@types/react-test-renderer": "^17.0.1", "@types/scheduler": "^0.16.2", - "@types/three": "^0.130.0", + "@types/three": "^0.133.0", "@typescript-eslint/eslint-plugin": "^4.28.4", "@typescript-eslint/parser": "^4.28.4", "eslint": "^7.31.0", diff --git a/packages/fiber/src/three-types.ts b/packages/fiber/src/three-types.ts index 7a681df3bf..47d4d7bc76 100644 --- a/packages/fiber/src/three-types.ts +++ b/packages/fiber/src/three-types.ts @@ -119,10 +119,6 @@ export type OctahedronBufferGeometryProps = BufferGeometryNode< THREE.OctahedronBufferGeometry, typeof THREE.OctahedronBufferGeometry > -export type ParametricBufferGeometryProps = BufferGeometryNode< - THREE.ParametricBufferGeometry, - typeof THREE.ParametricBufferGeometry -> export type PlaneBufferGeometryProps = BufferGeometryNode export type PolyhedronBufferGeometryProps = BufferGeometryNode< THREE.PolyhedronBufferGeometry, @@ -138,7 +134,6 @@ export type TetrahedronBufferGeometryProps = BufferGeometryNode< THREE.TetrahedronBufferGeometry, typeof THREE.TetrahedronBufferGeometry > -export type TextBufferGeometryProps = BufferGeometryNode export type TorusBufferGeometryProps = BufferGeometryNode export type TorusKnotBufferGeometryProps = BufferGeometryNode< THREE.TorusKnotBufferGeometry, @@ -146,7 +141,6 @@ export type TorusKnotBufferGeometryProps = BufferGeometryNode< > export type TubeBufferGeometryProps = BufferGeometryNode export type WireframeGeometryProps = BufferGeometryNode -export type ParametricGeometryProps = BufferGeometryNode export type TetrahedronGeometryProps = BufferGeometryNode export type OctahedronGeometryProps = BufferGeometryNode export type IcosahedronGeometryProps = BufferGeometryNode @@ -158,7 +152,6 @@ export type PolyhedronGeometryProps = BufferGeometryNode export type TorusKnotGeometryProps = BufferGeometryNode export type TorusGeometryProps = BufferGeometryNode -export type TextGeometryProps = BufferGeometryNode export type SphereGeometryProps = BufferGeometryNode export type RingGeometryProps = BufferGeometryNode export type PlaneGeometryProps = BufferGeometryNode @@ -290,19 +283,16 @@ declare global { icosahedronBufferGeometry: IcosahedronBufferGeometryProps latheBufferGeometry: LatheBufferGeometryProps octahedronBufferGeometry: OctahedronBufferGeometryProps - parametricBufferGeometry: ParametricBufferGeometryProps planeBufferGeometry: PlaneBufferGeometryProps polyhedronBufferGeometry: PolyhedronBufferGeometryProps ringBufferGeometry: RingBufferGeometryProps shapeBufferGeometry: ShapeBufferGeometryProps sphereBufferGeometry: SphereBufferGeometryProps tetrahedronBufferGeometry: TetrahedronBufferGeometryProps - textBufferGeometry: TextBufferGeometryProps torusBufferGeometry: TorusBufferGeometryProps torusKnotBufferGeometry: TorusKnotBufferGeometryProps tubeBufferGeometry: TubeBufferGeometryProps wireframeGeometry: WireframeGeometryProps - parametricGeometry: ParametricGeometryProps tetrahedronGeometry: TetrahedronGeometryProps octahedronGeometry: OctahedronGeometryProps icosahedronGeometry: IcosahedronGeometryProps @@ -311,7 +301,6 @@ declare global { tubeGeometry: TubeGeometryProps torusKnotGeometry: TorusKnotGeometryProps torusGeometry: TorusGeometryProps - textGeometry: TextGeometryProps sphereGeometry: SphereGeometryProps ringGeometry: RingGeometryProps planeGeometry: PlaneGeometryProps diff --git a/yarn.lock b/yarn.lock index 7db78a0a3f..fe150dbeb0 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1881,10 +1881,10 @@ resolved "https://registry.yarnpkg.com/@types/stack-utils/-/stack-utils-2.0.1.tgz#20f18294f797f2209b5f65c8e3b5c8e8261d127c" integrity sha512-Hl219/BT5fLAaz6NDkSuhzasy49dwQS/DSdu4MdggFB8zcXv7vflBI3xp7FEmkmdDkBUI2bPUNeMttp2knYdxw== -"@types/three@^0.130.0": - version "0.130.0" - resolved "https://registry.yarnpkg.com/@types/three/-/three-0.130.0.tgz#f048f1fb73e789a2c0dfcc66a45ffcbf259a75f6" - integrity sha512-7MKKxlEjHoAGTBRxEcDOjO4OvOrvUM6xtyjPiubNcU6bRPNmjNaV/PI9tiaXkk8cauZ9FuRbdCV4g0rQod+FkQ== +"@types/three@^0.133.0": + version "0.133.1" + resolved "https://registry.yarnpkg.com/@types/three/-/three-0.133.1.tgz#6007faaf7f6b53339150a2a1fe57121e4c6607c1" + integrity sha512-XqBrP/+kbs+o0CYRhCVVE95v7FaL2bO5Z7+3VQJE0nEyjo+9LoLfeNgZITOnndKHxM+7ltEciAIR7uE0SZlsOg== "@types/yargs-parser@*": version "20.2.1"