From 2895eb8f6933e46f78e4e79f859c9b5f842e8d1d Mon Sep 17 00:00:00 2001 From: adrian-wojcik Date: Thu, 14 Mar 2024 15:08:01 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Changed=20env=20default=20value?= =?UTF-8?q?=20'PROD'=20to=20'DEV'?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- viadot/flows/sap_rfc_to_adls.py | 4 ++-- viadot/tasks/sap_rfc.py | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/viadot/flows/sap_rfc_to_adls.py b/viadot/flows/sap_rfc_to_adls.py index a4f65eb3c..009296d44 100644 --- a/viadot/flows/sap_rfc_to_adls.py +++ b/viadot/flows/sap_rfc_to_adls.py @@ -18,7 +18,7 @@ def __init__( rfc_unique_id: List[str] = None, sap_credentials: dict = None, sap_credentials_key: str = "SAP", - env: str = "PROD", + env: str = "DEV", output_file_extension: str = ".parquet", local_file_path: str = None, file_sep: str = "\t", @@ -70,7 +70,7 @@ def __init__( ) sap_credentials (dict, optional): The credentials to use to authenticate with SAP. By default, they're taken from the local viadot config. sap_credentials_key (str, optional): Local config or Azure KV secret. Defaults to "SAP". - env (str, optional): SAP environment. Defaults to "PROD". + env (str, optional): SAP environment. Defaults to "DEV". output_file_extension (str, optional): Output file extension - to allow selection of .csv for data which is not easy to handle with parquet. Defaults to ".parquet". local_file_path (str, optional): Local destination path. Defaults to None. file_sep(str, optional): The separator to use in the CSV. Defaults to "\t". diff --git a/viadot/tasks/sap_rfc.py b/viadot/tasks/sap_rfc.py index 1925439df..b2ef7552b 100644 --- a/viadot/tasks/sap_rfc.py +++ b/viadot/tasks/sap_rfc.py @@ -26,7 +26,7 @@ def __init__( rfc_total_col_width_character_limit: int = 400, sap_credentials: dict = None, sap_credentials_key: str = "SAP", - env: str = "PROD", + env: str = "DEV", max_retries: int = 3, retry_delay: timedelta = timedelta(seconds=10), timeout: int = 3600, @@ -60,7 +60,7 @@ def __init__( of characters, so we add a safety margin. Defaults to 400. sap_credentials (dict, optional): The credentials to use to authenticate with SAP. By default, they're taken from the local viadot config. sap_credentials_key (str, optional): Local config or Azure KV secret. Defaults to "SAP". - env (str, optional): SAP environment. Defaults to "PROD". + env (str, optional): SAP environment. Defaults to "DEV". By default, they're taken from the local viadot config. """ self.query = query @@ -96,7 +96,7 @@ def run( replacement: str = "-", sap_credentials: dict = None, sap_credentials_key: str = "SAP", - env: str = "PROD", + env: str = "DEV", func: str = None, rfc_total_col_width_character_limit: int = None, rfc_unique_id: List[str] = None, @@ -112,7 +112,7 @@ def run( inside the string to avoid flow breakdowns. Defaults to "-". sap_credentials (dict, optional): The credentials to use to authenticate with SAP. By default, they're taken from the local viadot config. sap_credentials_key (str, optional): Local config or Azure KV secret. Defaults to "SAP". - env (str, optional): SAP environment. Defaults to "PROD". + env (str, optional): SAP environment. Defaults to "DEV". func (str, optional): SAP RFC function to use. Defaults to None. rfc_total_col_width_character_limit (int, optional): Number of characters by which query will be split in chunks in case of too many columns for RFC function. According to SAP documentation, the limit is