Moved plugin functionality to python-workflows

Author: davidigandan

pyproject.toml

@@ -53,6 +53,7 @@ OfflineTransport = "workflows.transport.offline_transport:OfflineTransport"
 pika = "workflows.util.zocalo.configuration:Pika"
 stomp = "workflows.util.zocalo.configuration:Stomp"
 transport = "workflows.util.zocalo.configuration:DefaultTransport"
+opentelemetry = "workflows.util.zocalo.configuration:OTEL"
 
 [project.scripts]
 "workflows.validate_recipe" = "workflows.recipe.validate:main"

src/workflows/services/common_service.py

@@ -18,7 +18,6 @@
 import workflows
 import workflows.logging
 from workflows.transport.middleware.otel_tracing import OTELTracingMiddleware
-from workflows.util.zocalo.configuration import OTEL
 
 
 class Status(enum.Enum):
@@ -193,38 +192,47 @@ def start_transport(self):
             self.transport.subscription_callback_set_intercept(
                 self._transport_interceptor
             )
-
-            # Configure OTELTracing if configuration is available
-            otel_config = (
-                OTEL.config if hasattr(OTEL, "config") and OTEL.config else None
-            )
-
-            if otel_config:
-                # Configure OTELTracing
-                resource = Resource.create(
-                    {
-                        SERVICE_NAME: self._service_name,
-                    }
+            try:
+                # Configure OTELTracing if configuration is available
+                otel_config = (
+                    self.config.opentelemetry if self.config and hasattr(self.config, "opentelemetry") else None
                 )
 
-                self.log.debug("Configuring OTELTracing")
-                provider = TracerProvider(resource=resource)
-                trace.set_tracer_provider(provider)
+                if otel_config:
+                    if "endpoint" not in otel_config:
+                        self.log.warning("Missing required OTEL configuration field `endpoint`.")
+                    
+                    if "timeout" not in otel_config:
+                        self.log.warning("Missing optional OTEL configuration field `timout`. Will default to 10 seconds. ")
+
+                    # Configure OTELTracing
+                    resource = Resource.create(
+                        {
+                            SERVICE_NAME: self._service_name,
+                        }
+                    )
 
-                # Configure BatchProcessor and OTLPSpanExporter using config values
-                otlp_exporter = OTLPSpanExporter(
-                    endpoint=otel_config["endpoint"],
-                    timeout=otel_config.get("timeout", 10),
-                )
-                span_processor = BatchSpanProcessor(otlp_exporter)
-                provider.add_span_processor(span_processor)
+                    self.log.debug("Configuring OTELTracing")
+                    provider = TracerProvider(resource=resource)
+                    trace.set_tracer_provider(provider)
 
-            # Add OTELTracingMiddleware to the transport layer
-            tracer = trace.get_tracer(__name__)
-            otel_middleware = OTELTracingMiddleware(
-                tracer, service_name=self._service_name
-            )
-            self._transport.add_middleware(otel_middleware)
+                    # Configure BatchProcessor and OTLPSpanExporter using config values
+                    otlp_exporter = OTLPSpanExporter(
+                        endpoint=otel_config["endpoint"],
+                        timeout=otel_config.get("timeout", 10),
+                    )
+                    span_processor = BatchSpanProcessor(otlp_exporter)
+                    provider.add_span_processor(span_processor)
+
+                    # Add OTELTracingMiddleware to the transport layer
+                    tracer = trace.get_tracer(__name__)
+                    otel_middleware = OTELTracingMiddleware(
+                        tracer, service_name=self._service_name
+                    )
+                    self._transport.add_middleware(otel_middleware)
+            except Exception as e:
+                # Continue without tracing if configuration fails
+                self.log.warning("Failed to configure OpenTelemetry tracing: %s", str(e))
 
             metrics = self._environment.get("metrics")
             if metrics: