ci: fix success job (#32)

GitHub considers skipped jobs as fulfilling requirements when merging
pull requests. We need to ensure that the success job fails if any
previous job has failed.

Author: CBenoit

.github/workflows/ci.yml

@@ -64,11 +64,17 @@ jobs:
   success:
     name: Success
     runs-on: ubuntu-latest
-    if: ${{ success() }}
+    if: ${{ always() }}
     needs:
       - formatting
       - checks
 
     steps:
       - name: CI succeeded
+        id: succeeded
+        if: ${{ !contains(needs.*.result, 'failure') }}
         run: exit 0
+
+      - name: CI failed
+        if: ${{ steps.succeeded.outcome == 'skipped' }}
+        run: exit 1