Skip to content

build(deps): update axum to 0.8 and tungstenite and tokio-tungstenite to 0.26 #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

RRRadicalEdward
Copy link
Collaborator

No description provided.

@@ -27,8 +28,8 @@ pub fn make_router<S>(state: DgwState) -> Router<S> {
use axum::routing::{self, get, MethodFilter};

let router = Router::new()
.route("/tcp/:id", get(fwd_tcp))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if use : for a path segment, it will produce Path segments must not start with *. For wildcard capture, use {*wildcard}. If you meant to literally match a segment starting with an asterisk, call without_v07_checks on the router error. Seems like, they have changed the way, we define a path segment - https://docs.rs/axum/latest/axum/routing/struct.Router.html#method.route. : is no longer an option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@RRRadicalEdward
Copy link
Collaborator Author

@CBenoit please review :)

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Alex!

@CBenoit CBenoit changed the title refactor(deps): bump versions of axum to 0.8, tungstenite and tokio-tungstenite to 0.26 build(deps): update axum to 0.8 and tungstenite and tokio-tungstenite to 0.26 Apr 14, 2025
@CBenoit CBenoit merged commit 06e91df into Devolutions:master Apr 14, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants