ci: enforce clippy lints

Author: CBenoit

.github/workflows/ci.yml

@@ -139,6 +139,34 @@ jobs:
           name: version
           path: VERSION
 
+  lints:
+    name: lints [${{ matrix.os }}]
+    needs: [preflight]
+    runs-on: ${{ matrix.runner }}
+    strategy:
+      matrix:
+        os: [windows, linux]
+        include:
+          - os: windows
+            runner: windows-2022
+          - os: linux
+            runner: ubuntu-latest
+
+    steps:
+      - name: Checkout ${{ github.repository }}
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ needs.preflight.outputs.ref }}
+
+      - name: Check clippy
+        shell: pwsh
+        run: |
+          cargo clippy --workspace --tests -- -D warnings
+          if ($LASTEXITCODE -ne 0) {
+              Write-Output "::error::Clippy warnings detected, please run 'cargo clippy --workspace --tests' and fix all warnings"
+              exit 1
+          }
+
   tests:
     name: tests [${{ matrix.os }} ${{ matrix.arch }}]
     needs: [preflight]
@@ -1058,7 +1086,7 @@ jobs:
   success:
     name: Success
     if: ${{ always() }}
-    needs: [tests, check-dependencies, jetsocat-lipo, devolutions-gateway-powershell, devolutions-gateway, devolutions-gateway-merge, devolutions-pedm-desktop, devolutions-agent, devolutions-agent-merge, devolutions-pedm-client, dotnet-utils-tests, winapi-sanitizer-tests, winapi-miri, pedm-simulator]
+    needs: [tests, lints, check-dependencies, jetsocat-lipo, devolutions-gateway-powershell, devolutions-gateway, devolutions-gateway-merge, devolutions-pedm-desktop, devolutions-agent, devolutions-agent-merge, devolutions-pedm-client, dotnet-utils-tests, winapi-sanitizer-tests, winapi-miri, pedm-simulator]
     runs-on: ubuntu-latest
 
     steps:

crates/sysevent-winevent/src/lib.rs

@@ -20,7 +20,7 @@ impl WinEvent {
     /// The source name should match a registered event source in the Windows Registry
     /// for proper message formatting and categorization.
     pub fn new(source_name: &str) -> Result<Self, SysEventError> {
-        let source_name_utf16 = to_null_terminated_utf16(source_name.as_ref());
+        let source_name_utf16 = to_null_terminated_utf16(source_name);
 
         // SAFETY: Proper UTF-16, null-terminated string.
         let handle = unsafe { EventLog::RegisterEventSourceW(std::ptr::null(), source_name_utf16.as_ptr()) };
@@ -70,6 +70,10 @@ impl WinEvent {
 
         // Prepare strings for structured logging.
         let mut string_ptrs = Vec::new(); // Will be actually used as the parameter of the FFI function.
+        #[expect(
+            clippy::collection_is_never_read,
+            reason = "string_ptrs hold pointers to the string we store inside this Vec"
+        )]
         let mut utf16_strings = Vec::new(); // Keep the UTF-16 strings alive.
 
         // Add the English message as the first parameter for debugging context.

devolutions-gateway/build.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::unwrap_used, reason = "panics are build script errors")]
+
 fn main() {
     #[cfg(target_os = "windows")]
     win::embed_version_rc();
@@ -27,7 +29,7 @@ mod win {
         let company_name = "Devolutions Inc.";
         let legal_copyright = format!("Copyright 2020-2023 {}", company_name);
 
-        let version_number = env::var("CARGO_PKG_VERSION").unwrap() + ".0";
+        let version_number = format!("{}.0", env::var("CARGO_PKG_VERSION").unwrap());
         let version_commas = version_number.replace('.', ",");
         let file_description = output_name;
         let file_version = version_number.clone();