You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* This function is provided for demonstration purposes only.
a bit misleading.
My point is that the comment uses "should", where it can be made more clear that an instance of that class is indeed passed. I.e. the inexperienced reader does not have to do it, it's already done even if the function is for "demostration purposes only".
Moreover it's not the run() function creating or passing the instance.
A very cheap proposal is (need english rework):
/**
* This function is provided for demonstration purposes only.
* It will add_filter() the default plugin script or sytle.
*
* With the current plugin structure, an instance of this class
* is created by Plugin_Name and then passed to add_action()
* defined in Plugin_Name_Loader.
*
* Then, the run() function defined in Plugin_Name_Loader will
* connect all the hooks you have registered with add_action()
* in the plugin with wordpress hooks by calling add_filter()
* on each.
*
*/
The text was updated successfully, but these errors were encountered:
Hello,
I found this comment:
WordPress-Plugin-Boilerplate/plugin-name/public/class-plugin-name-public.php
Line 65 in a829108
a bit misleading.
My point is that the comment uses "should", where it can be made more clear that an instance of that class is indeed passed. I.e. the inexperienced reader does not have to do it, it's already done even if the function is for "demostration purposes only".
Moreover it's not the run() function creating or passing the instance.
A very cheap proposal is (need english rework):
The text was updated successfully, but these errors were encountered: