Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open-bench crashes #17

Merged
merged 26 commits into from
Nov 21, 2024
Merged

fix: open-bench crashes #17

merged 26 commits into from
Nov 21, 2024

Conversation

DeveloperPaul123
Copy link
Owner

Changes

  • This addresses many of the issues seen when running open bench tests. We have still not addressed all issues as there are still stalls and time forfeits, but it's a step in the right direction.
  • Added multi-thread support so that search can be interrupted and stopped. Command line parsing is done in a separate thread in addition to search.
  • Updated the gitignore
  • Added some more scripts and tooling that have helped to some degree with debugging my engine.

See #8

bench: 1994757

DeveloperPaul123 and others added 26 commits November 12, 2024 19:05
Don't throw error if parsing failed

bench: 1994757
Search will now stop close to "max_nodes". Not guaranteed to be exact.
Fixed a bug in `make_uci_move` that was caused by `as_number()` for the `Rank` object. Also moved to using `make_move_unchecked` in `make_uci_move`

bench: 1994757
Worker thread that manages a thread, sender, receiver and provides a stopping mechanism
Added a worker that handles stdin input, parses it and sends out UciCommands.
Moved search to be used from a dedicated thread.
Now use `engine.run()` in main and let the engine handle the loop of processing commands and reacting to them.

bench: 1994757
feat: add support  for basic search cancelation
Ensure that the tt-move gets the _best_ possible score.
bench: 1994757
bench: 1994757
chore: update how tt-move scoring is done.
@DeveloperPaul123 DeveloperPaul123 merged commit ca1759f into main Nov 21, 2024
1 check passed
@DeveloperPaul123 DeveloperPaul123 deleted the fix/open-bench-crashes branch November 21, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant