Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: experimental multiple windows in native automation #8080

Merged
merged 1 commit into from
Dec 19, 2023
Merged

feat: experimental multiple windows in native automation #8080

merged 1 commit into from
Dec 19, 2023

Conversation

AlexKamaev
Copy link
Contributor

No description provided.

@AlexKamaev AlexKamaev changed the title [WIP]experimental multiple windows in native automation experimental multiple windows in native automation Dec 18, 2023
@aleks-pro aleks-pro changed the title experimental multiple windows in native automation feat: experimental multiple windows in native automation Dec 19, 2023
@aleks-pro aleks-pro marked this pull request as ready for review December 19, 2023 11:15
aleks-pro
aleks-pro approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@aleks-pro aleks-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to check here if multiple mode enabled

@AlexKamaev
Copy link
Contributor Author

Decided to check here if multiple mode enabled

I've checked it. In general, we cannot pass the experimentalMultipleWindows option into the openBrowser function, since browser can be opened before the experimentalMultipleWindows options is set (as in our tests).

So, I'll merge it as is. If it would be neccessary, I'll check the possible fixes for this in near future.

@AlexKamaev AlexKamaev merged commit 640cf6b into DevExpress:master Dec 19, 2023
4 of 8 checks passed
@AlexKamaev
Copy link
Contributor Author

All tests passed. I just add fix for package-lock.json file.

@github-actions GitHub Actions
Copy link

Release v3.5.0-rc.1 addresses this.

1 similar comment
@github-actions GitHub Actions
Copy link

Release v3.5.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titerman titerman titerman left review comments

@aleks-pro aleks-pro aleks-pro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKamaev @aleks-pro @titerman