Fix lint errors

Author: DuckTieCorpMember

Angular/src/app/app.component.ts

@@ -44,11 +44,11 @@ export class AppComponent {
   }
 
   onEditingStart(e: DxDataGridTypes.EditingStartEvent): void {
-    this.subjects = [...e.data.Subjects || []];
+    this.subjects = [...e.data.Subjects ?? []];
   }
 
   onEditorPreparing(e: DxDataGridTypes.EditorPreparingEvent): void {
-    this.canBeSaved = e.row?.isNewRow || false;
+    this.canBeSaved = e.row?.isNewRow ?? false;
     this.key = e.row?.key;
   }
 

React/src/components/Home.tsx

@@ -4,7 +4,7 @@ import React, {
 import DataGrid, {
   Column, Editing, Popup, Form, ToolbarItem, ValidationRule,
   type DataGridRef,
-  type DataGridTypes
+  type DataGridTypes,
 } from 'devextreme-react/data-grid';
 import Button from 'devextreme-react/button';
 import { getStudentRows, getStudents } from '../sevices/employee';
@@ -56,7 +56,7 @@ export function HomeComponent(): JSX.Element {
     setSaveDisabled(copy.length === 0 && !e.data?.ID);
   }, []);
 
-  const onInitNewRow = useCallback((_e: DataGridTypes.InitNewRowEvent) => {
+  const onInitNewRow = useCallback(() => {
     setEditingKey(null);
     editingSubjectsRef.current = [];
     setSaveDisabled(true);
@@ -74,7 +74,7 @@ export function HomeComponent(): JSX.Element {
     gridRef,
   }), [setSubjectsRefCallback, saveDisabled, setSaveDisabled]);
 
-  const onSaved = useCallback((_e: DataGridTypes.SavedEvent) => {
+  const onSaved = useCallback(() => {
     const gridWidget = gridRef.current?.instance?.();
     const dsItems = gridWidget?.option('dataSource');
     if (Array.isArray(dsItems)) {
@@ -172,7 +172,7 @@ function SubjectsEditCell(): JSX.Element | null {
     setSaveDisabled(shouldDisable);
   }, [setSaveDisabled, isEditing]);
 
-  const onEditingStart = useCallback((_e: DataGridTypes.EditingStartEvent) => {
+  const onEditingStart = useCallback(() => {
     setIsEditing(true);
     setSaveDisabled(true);
   }, [setSaveDisabled]);

React/src/utils.ts

@@ -8,15 +8,25 @@ interface StateShape {
   isValid?: boolean;
 }
 
-type Action = 
+interface RowData {
+  data: {
+    [key: string]: any;
+    Name?: string;
+    Subjects?: any[];
+  };
+  type?: 'insert' | 'update' | 'remove';
+  isNewRow?: boolean;
+}
+
+type Action =
   | { type: 'Saving'; payload: { data?: any; key?: string } }
   | { type: 'Set_Changes'; payload: { changes: any[]; isValid: boolean } }
   | { type: 'Set_Key'; payload: string | number | null }
   | { type: 'Set_Valid'; payload: boolean };
 
 function reducer(state: StateShape, action: Action): StateShape {
   switch (action.type) {
-    case 'Saving':
+    case 'Saving': {
       if (!action.payload.data) action.payload.data = {};
 
       const newData = applyChanges(state.data, [action.payload.data], { keyExpr: action.payload.key });
@@ -28,6 +38,7 @@ function reducer(state: StateShape, action: Action): StateShape {
         changes: [],
         editRowKey: null,
       };
+    }
     case 'Set_Changes':
       return {
         ...state,
@@ -49,16 +60,6 @@ function reducer(state: StateShape, action: Action): StateShape {
   }
 }
 
-interface RowData {
-  type?: 'insert' | 'update' | 'remove';
-  isNewRow?: boolean;
-  data: {
-    Name?: string;
-    Subjects?: any[];
-    [key: string]: any;
-  };
-}
-
 function checkIsValid(row: RowData): boolean {
   let result = true;
   if (row.type === 'insert' || row.isNewRow === true) {
@@ -70,7 +71,4 @@ function checkIsValid(row: RowData): boolean {
   return result;
 }
 
-export {
-  reducer,
-  checkIsValid,
-};
+export { reducer, checkIsValid };

Vue/src/App.vue

@@ -100,10 +100,12 @@ import SubjectsEditorComponent from './components/SubjectsEditorComponent.vue';
 const dataSource = ref<StudentSubject[]>(studentSubjects);
 const studentsData = ref<Student[]>(students);
 const currentSubjects = ref<Subject[]>([]);
-const popupInstance = ref<any>(null); // DevExtreme popup component instance - keeping as any due to complex DX component typing
+// DevExtreme popup component instance - keeping as any due to complex DX component typing
+const popupInstance = ref<any>(null);
 const canBeSaved = ref<boolean>(false);
 const editingKey = ref<string | number | null>(null);
-const mainGrid = ref<any>(null); // DevExtreme DataGrid component instance - keeping as any due to complex DX component typing
+// DevExtreme DataGrid component instance - keeping as any due to complex DX component typing
+const mainGrid = ref<any>(null);
 
 const saveButtonOptions = reactive({
   text: 'Save',
@@ -117,23 +119,26 @@ const cancelButtonOptions = reactive({
   onClick: () => cancelMainGrid()
 });
 
-const subjectsCellTemplate = (container: HTMLElement, options: { value?: Subject[]; target?: string }) => {
+const subjectsCellTemplate = (
+  container: HTMLElement,
+  options: { value?: Subject[]; target?: string }
+) => {
   if (options.value && options.value.length > 0) {
     const text = options.value.map((subject: Subject) => subject.Name).join(', ');
     container.textContent = text;
   }
 };
 
 const onEditingStart = (e: DxDataGridTypes.EditingStartEvent) => {
-  currentSubjects.value = [...(e.data.Subjects || [])];
+  currentSubjects.value = [...(e.data.Subjects ?? [])];
 };
 
 const onEditorPreparing = (e: DxDataGridTypes.EditorPreparingEvent) => {
-  canBeSaved.value = e.row?.isNewRow || false;
+  canBeSaved.value = e.row?.isNewRow ?? false;
   editingKey.value = e.row?.key;
 };
 
-const onInitNewRow = (_e: DxDataGridTypes.InitNewRowEvent) => {
+const onInitNewRow = () => {
   currentSubjects.value = [];
 };
 
@@ -149,15 +154,17 @@ const onSubjectsChange = (subjects: Subject[]) => {
   currentSubjects.value = subjects;
 };
 
-const onNestedEditingStart = (_e: DxDataGridTypes.EditingStartEvent) => {
+const onNestedEditingStart = () => {
   updateSaveButtonState(true);
 };
 
 const onNestedRowValidating = (e: { isValid: boolean }) => {
   updateSaveButtonState(!e.isValid);
 };
 
-const onNestedSaved = (e: { component: { getDataSource: () => { items: () => Subject[] } } }) => {
+const onNestedSaved = (
+  e: { component: { getDataSource: () => { items: () => Subject[] } } }
+) => {
   currentSubjects.value = e.component.getDataSource().items();
   const hasSubjects = currentSubjects.value.length > 0;
   updateSaveButtonState(!hasSubjects);