chore: change logging defaults (#27)

* change logging defaults

* void gin logs differently

Author: JamieSinn

README.md

@@ -17,6 +17,9 @@ preventing the need for network calls.
 The HTTP server mode is a 1:1 replacement for the Bucketing API used by all SDKs in cloud bucketing mode, or can be used
 directly without an SDK as an API.
 
+Logging can be configured to write to a file for both application logs, and HTTP access logs; or just writing application
+logs to `stdout`. By default, the application logs are written to `stdout`, and the HTTP logs are written to `/dev/null`.
+
 ### Docker
 
 The docker image published here is the base runtime version - expecting to be used as a base image for you to extend.

proxy.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"github.com/devcyclehq/go-server-sdk/v2/api"
 	"github.com/launchdarkly/eventsource"
-	"io"
 	"log"
 	"os"
 	"strconv"
@@ -16,14 +15,17 @@ import (
 
 func NewBucketingProxyInstance(instance *ProxyInstance) (*ProxyInstance, error) {
 	gin.DisableConsoleColor()
-	logFile, err := os.OpenFile(instance.LogFile, os.O_CREATE|os.O_APPEND|os.O_RDWR, 0666)
-	if err != nil {
-		_ = fmt.Errorf("error opening log file: %s", err)
-		return nil, err
+	if instance.LogFile != "" {
+		logFile, err := os.OpenFile(instance.LogFile, os.O_CREATE|os.O_APPEND|os.O_RDWR, 0666)
+		if err != nil {
+			_ = fmt.Errorf("error opening log file: %s", err)
+			return nil, err
+		}
+		gin.DefaultWriter = logFile
+		log.SetOutput(logFile)
+	} else {
+		log.SetOutput(os.Stdout)
 	}
-	mw := io.MultiWriter(os.Stdout, logFile)
-	log.SetOutput(mw)
-	gin.DefaultWriter = mw
 	if instance.SSEEnabled {
 		instance.sseEvents = make(chan api.ClientEvent, 100)
 		instance.sseServer = eventsource.NewServer()
@@ -100,7 +102,9 @@ func sdkProxyMiddleware(instance *ProxyInstance) gin.HandlerFunc {
 func newRouter(client *devcycle.Client, instance *ProxyInstance) *gin.Engine {
 	r := gin.New()
 
-	r.Use(gin.Logger())
+	if instance.LogFile != "" {
+		r.Use(gin.Logger())
+	}
 	r.Use(gin.Recovery())
 	r.Use(devCycleMiddleware(client))
 	r.Use(sdkProxyMiddleware(instance))