Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Workspace support? #156

Open
RaitoBezarius opened this issue Oct 3, 2022 · 3 comments
Open

Workspace support? #156

RaitoBezarius opened this issue Oct 3, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@RaitoBezarius
Copy link

Is riff supposed to support Cargo workspace or does it have any plan to do so?

@cole-h cole-h added the enhancement New feature or request label Oct 11, 2022
@cole-h
Copy link
Member

cole-h commented Oct 11, 2022

Do you have an example repository that uses Cargo workspaces where riff doesn't work well? I think it should work fine in workspaces and non-workspaces alike, but maybe that's not the case (and no project immediately comes to mind that I could test with and verify).

@RaitoBezarius
Copy link
Author

I tested it on a private monorepo project, alas, so I cannot share it.

What happened is there is no Cargo.toml at the root but it seems like there was some sort .cargo/Cargo.toml in the monorepo linking to each of the sub-projects.
riff was working fine in the sub-project, but not really at the root.

I will see if I can create a reproducer but I was more like: let's see how magic this is — so I need some time to ascertain what happened exactly.

@cole-h
Copy link
Member

cole-h commented Oct 12, 2022

I can't reproduce the issue. Maybe that repo is using some non-standard method of defining a workspace? Could you post the error output (or DM it to me on Matrix: @cole-h:matrix.org)? I tested with https://github.com/alacritty/alacritty and https://github.com/zellij-org/zellij, both of which use Cargo workspaces, and they seemed to build just fine for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants