Add support for indirect symbolic reference mangled names #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mangled names that start with \x02 are indirect: they point through a pointer rather than directly to the context descriptor.
Formatting, typos, codifying the indentation style, moving swift-source in-tree, and updating the gitignore to match
|
Looks good. Good idea on moving the swift-source in house : ] |
lapcat
pushed a commit
to lapcat/dsdump
that referenced
this pull request
Dec 10, 2019
…der#5) * Support indirect symbolic references Mangled names that start with \x02 are indirect: they point through a pointer rather than directly to the context descriptor. * Miscellaneous nitpicks Formatting, typos, codifying the indentation style, moving swift-source in-tree, and updating the gitignore to match
lapcat
added a commit
to lapcat/dsdump
that referenced
this pull request
Dec 10, 2019
…rekSelander#5)" This reverts commit 49a0b64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift compiler emits indirect symbolic references in certain cases which cause dsdump to behave undesirably when it encounters them. This pull request fixes that. It also contains some assorted changes that I made to make my life better/easier; feel free to pick and choose the parts you want or ask me why I changed something.