Remove load_defaults in favor of better helper

Previous specs were full of `load_defaults` and `reload_routes` at
random places that were probably meant to reset state left around by
other specs. I removed all of those in favor of a better behaved helper
that cleans up after itself, and explicit loading of the resources
needed by each spec. Doing this surfaced several other state leakages
which I fixed.

Author: deivid-rodriguez

spec/requests/default_namespace_spec.rb

@@ -79,8 +79,8 @@ def with_custom_default_namespace(namespace)
   def with_temp_application(application)
     original_application = ActiveAdmin.application
     ActiveAdmin.application = application
-    load_defaults!
-    reload_routes!
+
+    load_resources { ActiveAdmin.register(Category) }
 
     yield
 

spec/requests/memory_spec.rb

@@ -1,8 +1,8 @@
 require 'rails_helper'
 
 RSpec.describe "Memory Leak", type: :request, if: RUBY_ENGINE == 'ruby' do
-  before do
-    load_defaults!
+  around do |example|
+    with_resources_during(example) { ActiveAdmin.register(Category) }
   end
 
   def count_instances_of(klass)
@@ -15,7 +15,7 @@ def count_instances_of(klass)
       GC.start
       count = count_instances_of(klass)
 
-      load_defaults!
+      load_resources { ActiveAdmin.register(Category) }
 
       GC.start
       GC.disable if previously_disabled

spec/support/active_admin_integration_spec_helper.rb

@@ -1,10 +1,10 @@
 module ActiveAdminIntegrationSpecHelper
-  def load_defaults!
-    load_resources do
-      ActiveAdmin.register(Category)
-      ActiveAdmin.register(User)
-      ActiveAdmin.register(Post){ belongs_to :user, optional: true }
-    end
+  def with_resources_during(example)
+    load_resources { yield }
+
+    example.run
+
+    load_resources {}
   end
 
   def reload_menus!

spec/unit/namespace_spec.rb

@@ -40,6 +40,10 @@
         Admin.send(:remove_const, 'PostsController')
       end
 
+      after do
+        load_resources {}
+      end
+
       it "should not crash" do
         expect { ActiveAdmin.unload! }.not_to raise_error
       end

spec/unit/page_spec.rb

@@ -5,7 +5,6 @@ module ActiveAdmin
   RSpec.describe Page do
 
     it_should_behave_like "ActiveAdmin::Resource"
-    before { load_defaults! }
 
     let(:application){ ActiveAdmin::Application.new }
     let(:namespace){ Namespace.new(application, :admin) }

spec/unit/resource/naming_spec.rb

@@ -2,9 +2,6 @@
 
 module ActiveAdmin
   RSpec.describe Resource, "Naming" do
-
-    before { load_defaults! }
-
     let(:application){ ActiveAdmin::Application.new }
     let(:namespace){ Namespace.new(application, :admin) }
 

spec/unit/resource/pagination_spec.rb

@@ -2,9 +2,6 @@
 
 module ActiveAdmin
   RSpec.describe Resource, "Pagination" do
-
-    before { load_defaults! }
-
     let(:application){ ActiveAdmin::Application.new }
     let(:namespace){ Namespace.new(application, :admin) }
 

spec/unit/resource/routes_spec.rb

@@ -1,20 +1,14 @@
 require 'rails_helper'
 
 RSpec.describe ActiveAdmin::Resource::Routes do
-
-  after do
-    load_defaults!
-    reload_routes!
-  end
-
   let(:application) { ActiveAdmin.application }
   let(:namespace) { application.namespace(:admin) }
 
   context "when in the admin namespace" do
     let(:config) { namespace.resource_for('Category') }
 
-    before do
-      load_resources { ActiveAdmin.register Category }
+    around do |example|
+      with_resources_during(example) { ActiveAdmin.register Category }
     end
 
     let(:category) { Category.new { |c| c.id = 123 } }
@@ -35,6 +29,10 @@
   context "when in the root namespace" do
     let!(:config) { ActiveAdmin.register Category, namespace: false }
 
+    around do |example|
+      with_resources_during(example) { config }
+    end
+
     after do
       application.namespace(:root).unload!
       application.namespaces.instance_variable_get(:@namespaces).delete(:root)
@@ -45,15 +43,17 @@
     end
 
     it "should generate a correct route" do
-      reload_routes!
       expect(config.route_collection_path).to eq "/categories"
     end
   end
 
   context "when registering a plural resource" do
     class ::News; def self.has_many(*); end end
     let!(:config) { ActiveAdmin.register News }
-    before{ reload_routes! }
+
+    around do |example|
+      with_resources_during(example) { config }
+    end
 
     it "should return the plural route with _index" do
       expect(config.route_collection_path).to eq "/admin/news"

spec/unit/resource/scopes_spec.rb

@@ -2,9 +2,6 @@
 
 module ActiveAdmin
   RSpec.describe Resource, "Scopes" do
-
-    before { load_defaults! }
-
     let(:application){ ActiveAdmin::Application.new }
     let(:namespace){ Namespace.new(application, :admin) }
 

spec/unit/resource_spec.rb

@@ -5,7 +5,10 @@ module ActiveAdmin
   RSpec.describe Resource do
 
     it_should_behave_like "ActiveAdmin::Resource"
-    before { load_defaults! }
+
+    around do |example|
+      with_resources_during(example) { namespace.register Category }
+    end
 
     let(:application){ ActiveAdmin::Application.new }
     let(:namespace){ Namespace.new(application, :admin) }
@@ -38,6 +41,10 @@ def config(options = {})
         expect(config.decorator_class).to eq nil
       end
       context 'when a decorator is defined' do
+        around do |example|
+          with_resources_during(example) { resource }
+        end
+
         let(:resource) { namespace.register(Post) { decorate_with PostDecorator } }
         specify '#decorator_class_name should return PostDecorator' do
           expect(resource.decorator_class_name).to eq '::PostDecorator'
@@ -64,6 +71,10 @@ def config(options = {})
     describe "#include_in_menu?" do
       subject{ resource }
 
+      around do |example|
+        with_resources_during(example) { resource }
+      end
+
       context "when regular resource" do
         let(:resource){ namespace.register(Post) }
         it { is_expected.to be_include_in_menu }
@@ -239,6 +250,10 @@ class MockResource
     describe '#find_resource' do
       let(:post) { double }
 
+      around do |example|
+        with_resources_during(example) { resource }
+      end
+
       context 'without a decorator' do
         let(:resource) { namespace.register(Post) }
 
@@ -284,6 +299,10 @@ class MockResource
           end
         end
 
+        after do
+          Admin.send(:remove_const, :"PostsController")
+        end
+
         it 'can find the post by controller finder' do
           allow(Post).to receive(:find_by_title!).with('title-name').and_return(post)