Fix iOS AppIcon and prepare build 43#31
Merged
Merged
Conversation
denuoweb
marked this pull request as ready for review
July 18, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Build 42 was already accepted by App Store Connect, so its icon cannot be replaced in place. The initial iOS shell retained an obsolete placeholder icon. Build 43 is the immutable follow-up that gives the App Store build the same production artwork as Android and prevents a mismatched archive from uploading.
Impact
The application runtime is unchanged. The affected-target classifier selects only the macOS iOS gate (
rust=false,android=false,ios=true). After this PR passes CI and is merged, the protected TestFlight workflow can sign and upload 0.5.0 (43).Checks
python3 dist/app-store/validate.py./scripts/check-version-consistency.shpython3 -m unittest tests.test_ios_screenshot_toolspython3 scripts/test_select_ios_simulator.pyshellcheck scripts/run-ios-gate.sh scripts/upload-ios-testflight.shbash -n scripts/run-ios-gate.sh scripts/upload-ios-testflight.shgit diff --check