Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image crop for candidate card with multiple candidacies #10

Closed
VirginiaDooley opened this issue Feb 24, 2021 · 1 comment
Closed

Image crop for candidate card with multiple candidacies #10

VirginiaDooley opened this issue Feb 24, 2021 · 1 comment

Comments

@VirginiaDooley
Copy link
Contributor

VirginiaDooley commented Feb 24, 2021

Issue and Steps to Reproduce

While working on the new Person Page, I noticed the candidate images are awkwardly cropped in some cases.

One candidacy: http://localhost:8000/person/7842/tony-devenish
Many candidacies: http://localhost:8000/person/1478/shaun-bailey

Screenshots

While the image for a candidate with one candidacy looks great:
Screen Shot 2021-02-24 at 10 19 44 AM
The image for a candidate with more than one candidacy is less so:
Screen Shot 2021-02-24 at 10 19 25 AM

@Heydon
Copy link
Collaborator

Heydon commented Mar 3, 2021

@VirginiaDooley Okay, I've adjusted this here: cb49071

Bear in mind it’s always going to be an imperfect algorithm to get the card image effect across all viewport dimensions without loads of redundant white-space or stretching the image.

example of the adjusted layout

@Heydon Heydon closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants