Skip to content

issue #1083 duplicate wells #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

luitjansl
Copy link
Contributor

Fixes #1083

Description

When importing wells, we now make sure that when the ipf file defines 2 or more wells with the same x, y , filter_top, filter_bottom and id, then the ID of the second well is appended with "_1", and so on for successive findings of a well with the same characteristics (_2, _3 etc).

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@luitjansl luitjansl changed the title added test issue_#1083_duplicate_wells Jun 24, 2024
@luitjansl luitjansl changed the title issue_#1083_duplicate_wells issue #1083 duplicate wells Jun 24, 2024
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I see the linter failed btw, so please format that. Approving in advance!

@luitjansl luitjansl merged commit 9f274bd into imod5_converter_feature_branch Jun 26, 2024
5 checks passed
@luitjansl luitjansl deleted the issue_#1083_duplicate_wells branch June 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants