Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling extension breaks launching extension development host #67

Closed
disco0 opened this issue May 21, 2021 · 2 comments
Closed

Enabling extension breaks launching extension development host #67

disco0 opened this issue May 21, 2021 · 2 comments
Labels
bug Something isn't working next patch release

Comments

@disco0
Copy link

disco0 commented May 21, 2021

Extension Version: 0.2.9

VS Code Information

Version: 1.57.0-insider
Commit: 0b355ffc89b2020a941ce149f2704acf13a49afd
Date: 2021-05-20T17:44:35.872Z (11 hrs ago)
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 18.7.0

Opened up another extension project, launched the extension development host and nothing happens, not even the prelaunch task—based on dev tools output I tried disabling the extension and everything went back to normal, tried reinstalling and the issue still presented after re-enabling.

Related error output in dev tools:

deltaxml.xslt-path error log

@pgfearo
Copy link
Member

pgfearo commented May 21, 2021

Thanks for reporting this issue.

There appear to be 3 parts to this problem that I need to resolve:

  1. Understand why the XSLT/XPath extension is being triggered in this context, and explore whether it's possible to stop this happening.
  2. The TaskProviders attempt to parse the tasks.json file which is not standard JSON, it is JSONC. There is a very crude attempt to 'fix' the JSONC so it can be parsed with the JSON parser - but we should move to using Microsofts JSONC parser.
  3. The exception case where the JSONC cannot still be passed should be handled properly.

@pgfearo pgfearo added bug Something isn't working next patch release labels May 21, 2021
@pgfearo
Copy link
Member

pgfearo commented Jun 4, 2021

Fixed in release v0.3.0

@pgfearo pgfearo closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next patch release
Projects
None yet
Development

No branches or pull requests

2 participants