Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatability with bpmn-iobpmn-io/vs-code-bpmn-io #62

Closed
dignin opened this issue May 12, 2021 · 2 comments
Closed

Incompatability with bpmn-iobpmn-io/vs-code-bpmn-io #62

dignin opened this issue May 12, 2021 · 2 comments

Comments

@dignin
Copy link

dignin commented May 12, 2021

Hey, after tracing back (with the help of the bpmn-io team) the collision with your extension in the following post:

bpmn-io/vs-code-bpmn-io#96 (comment)

I'd like to pass it on to you, that your plugin may break compatibility with other plugins regarding bpmn as well. I would love to be able to use both extensions simultaneously. Can you take a look if it's fixable on your side?

How to reproduce, vs-code-bpmn-io, then install your plugin. Notice the functionality from bmpn-io is gone. It just requries deactivation of your plugin, to make vs-code-bpmn-io work again.

Hope to hear from you. If you need more information, let me know.

@pgfearo
Copy link
Member

pgfearo commented May 12, 2021

I'll look into this compatibility and update here as soon as I have more info.

The quickest solution would be to modify package.json and remove bpmn from the list of XML file extensions (which was copied from VSCode's built in XML extension).

Obviously though I'd like to see if there are changes I can make to allow both extensions to function properly with this file type, for example to allow this extension's XML formatting feature.

@pgfearo
Copy link
Member

pgfearo commented May 15, 2021

To fix this issue I've added the bpmn language id specifically to this extension - instead of using the generic 'xml' language id. This extension now explicitly supports XML formatting, syntax highlighting and basic XML syntax checking for BPMN files.

@pgfearo pgfearo closed this as completed May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants