Skip to content

performance.hints in webpack can't be true #17526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

donaldpipowitch
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: see source code
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

Passing true throws here. Only false is valid.

I also created a PR to update the webpack docs as they are wrong, too. webpack/webpack.js.org#1342

@dt-bot
Copy link
Member

dt-bot commented Jun 27, 2017

types/webpack/index.d.ts

to authors (@tkqubo @mattlewis92 @bumbleblym @bcherny @tommytroylin). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@paulvanbrenk paulvanbrenk merged commit 2fdcef7 into DefinitelyTyped:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants