Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitization + Modernization: Findings, Groups, Notifications #8728

Merged
merged 19 commits into from
Sep 29, 2023

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Sep 25, 2023

In an effort to have a better understanding of what behaviors are currently supported, and in what capacity, this PR converts some of the larger function based views into class based views. This cleanup/modernization work is done to help prepare the code for larger v3 changes in the future.

@Maffooch Maffooch changed the title Sanitization + Modernization: Findings, Groups. Notifications Sanitization + Modernization: Findings, Groups, Notifications Sep 25, 2023
@github-actions github-actions bot added the ui label Sep 25, 2023
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

dojo/templates/dojo/notifications.html Show resolved Hide resolved
dojo/templates/dojo/notifications.html Show resolved Hide resolved
dojo/templates/dojo/notifications.html Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@Maffooch Maffooch marked this pull request as ready for review September 26, 2023 22:24
dojo/group/urls.py Outdated Show resolved Hide resolved
Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few relatively minor comments here..

dojo/finding/views.py Outdated Show resolved Hide resolved
dojo/notifications/helper.py Outdated Show resolved Hide resolved
dojo/finding/views.py Outdated Show resolved Hide resolved
Maffooch and others added 3 commits September 27, 2023 17:07
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Note: AccessLint seems stuck - it's dropped a comment that it's OK with this PR so moving forward with things.

@blakeaowens blakeaowens merged commit 8485cbf into DefectDojo:dev Sep 29, 2023
@Maffooch Maffooch deleted the class-views branch July 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants