simple metrics: count closed findings not opened in current month #12595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
Maffooch
approved these changes
Jun 12, 2025
hblankenship
approved these changes
Jun 12, 2025
dogboat
approved these changes
Jun 12, 2025
xansec
pushed a commit
to xansec/django-DefectDojo
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12534 and #12399
Simple metrics was only showing findings closed in the selected month when they were also opened in the selected month.
I t could be that was intentional at the time it was implemented, but I believe it makes more sense to count all findings that were closed in that month regardless of when they were opened.