This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
fix test and pretrained model loading #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoRenaud
approved these changes
Dec 10, 2020
graphprot/Metrics.py
Outdated
| @@ -54,20 +54,23 @@ def __init__(self, y_pred, y_hat, target, threshold=4, binary=True): | |||
|
|
|||
| if self.binary == True: | |||
|
|
|||
| self.y_pred = get_boolean( | |||
| y_pred_CM = get_boolean( | |||
There was a problem hiding this comment.
overall the naming of the variables is a tiny bit confusing for me. y_pred is fine but already y_hat is a strange name for the ground truth. The same for the CM that I don't fully understand what it stands for. The same apply for the names of the metrics FP, FN TP and TN that if you know what they are it probably makes perfect sense but otherwise not so much, Being a bit more verbose in the naming convention here would be better I think
There was a problem hiding this comment.
I updated all the naming to make it more clear. Can you have a look ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.