This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
fix memory leaks #16
Merged
fix memory leaks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoRenaud
approved these changes
Nov 16, 2020
| @@ -199,7 +199,11 @@ def load_one_graph(self, fname, mol): | |||
| #print('Load mol :', mol) | |||
|
|
|||
| f5 = h5py.File(fname, 'r') | |||
There was a problem hiding this comment.
a usual way of writing is is
with h5py.File(fname,'r') as f5:
grp = f5[mol]so that you are sure that the file is closed when the scope of the with statement is finshed
|
I've also added a code quality analysis. By default it's rather picky and now it flags a new trailing space. That's why we have the little red cross next to the commit. Depending on which editor you use you can install automatic formatting tools that fixes these small issues on save. Currently we mostly us VS code and there are tons of tools to format python code automatically |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.