Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python, dlclibrary, switch to pip install in tests #115

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sneakers-the-rat
Copy link
Collaborator

Sorta orthogonal duplicate related to #110 , thought it was worth a separate PR because it's sorta different from deciding on the tf cap, but involves it. so this probably needs modification/rebasing on whatever gets decided there but just wanted to have a (hopeful) fix for the tests on the books. this should also be a patch version bump and re-release whenever it and 110 get merged, not done in this PR.

tests failing because can't find url for model. updates in dlclibrary reflect those changes, but tests install old version because lockfile hasn't been updated.

so:

  • update deps:
    • python 3.7 is EOL
    • match last supported TF of DLC at 2.10
    • bump dlclibrary to current known good version
  • relock
  • run tests from pip install instead of poetry: poetry install good for tests when actively developing for reproducible environments with resolved dependency trees. since we're not actively developing this though, tests can get stale and fail to reflect the environment created when people install from pip, which use the pyproject.toml constraints rather than the lockfile. also since sunset is in near future, let's switch to pip install for maintenance reasons.

- tests failing because locking old version of dlclibrary and running tests from lockfile
- update deps:
  - python 3.7 is EOL,
  - match last supported TF of DLC at 2.10
- relock
- run tests from pip install instead since not actively developing/relocking.
@sneakers-the-rat
Copy link
Collaborator Author

also seems like python-package.yaml action should be removed, but didn't want to do too much in one pr yno

@MMathisLab
Copy link
Member

Cc @jeylau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants