Enhance ModelPathStore path normalization tests

Update tests in tests/utils/test_settings_store.py to exercise ModelPathStore normalization more robustly: use tmp_path to create real directories and files, assert _norm_existing_dir and _norm_existing_path return existing absolute paths (and that they are dir/file respectively), and handle None via _norm_existing_* helpers. Also adjust suggest_start_dir test to make cwd invalid by monkeypatching Path.cwd so the fallback to home is exercised. Removed the previous unreliable expanduser assertion.

Author: C-Achard

tests/utils/test_settings_store.py

@@ -98,15 +98,29 @@ def model_validate_json(raw: str):
 # -----------------------------
 # ModelPathStore helpers
 # -----------------------------
-def test_model_path_store_norm_handles_none_and_invalid(monkeypatch):
+def test_model_path_store_norm_handles_none_and_invalid(tmp_path: Path):
     s = InMemoryQSettings()
     mps = store.ModelPathStore(settings=s)
 
-    assert mps._norm(None) is None  # type: ignore[arg-type]
+    # None should normalize to None
+    assert mps._norm_existing_path(None) is None  # type: ignore[arg-type]
+    assert mps._norm_existing_dir(None) is None  # type: ignore[arg-type]
 
-    # Force Path.expanduser() to raise by passing something weird? Hard to do reliably.
-    # Instead just assert normal path expands/returns str.
-    assert mps._norm("~/somewhere") is not None
+    # Existing dir should normalize to an absolute path
+    d = tmp_path / "models"
+    d.mkdir()
+    norm_dir = mps._norm_existing_dir(str(d))
+    assert norm_dir is not None
+    assert Path(norm_dir).exists()
+    assert Path(norm_dir).is_dir()
+
+    # Existing file should normalize as existing path
+    f = d / "net.pt"
+    f.write_text("x")
+    norm_file = mps._norm_existing_path(str(f))
+    assert norm_file is not None
+    assert Path(norm_file).exists()
+    assert Path(norm_file).is_file()
 
 
 # -----------------------------
@@ -289,7 +303,12 @@ def test_model_path_store_suggest_start_dir_falls_back_to_home(tmp_path: Path, m
     fake_home = tmp_path / "home"
     fake_home.mkdir()
 
+    # Make cwd "invalid" so suggest_start_dir can't use it
+    fake_cwd = tmp_path / "does_not_exist"
+    assert not fake_cwd.exists()
+
     monkeypatch.setattr(store.Path, "home", lambda: fake_home)
+    monkeypatch.setattr(store.Path, "cwd", lambda: fake_cwd)
 
     assert mps.suggest_start_dir(fallback_dir=None) == str(fake_home)