Skip to content

Commit 7e4e845

Browse files
committed
Set stricter CSP header in redirect & error responses
1 parent 836ed62 commit 7e4e845

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

HISTORY.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
unreleased
2+
==========
3+
4+
* Set stricter CSP header in redirect & error responses
5+
16
0.17.0 / 2019-05-03
27
===================
38

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ SendStream.prototype.error = function error (status, err) {
288288
res.statusCode = status
289289
res.setHeader('Content-Type', 'text/html; charset=UTF-8')
290290
res.setHeader('Content-Length', Buffer.byteLength(doc))
291-
res.setHeader('Content-Security-Policy', "default-src 'self'")
291+
res.setHeader('Content-Security-Policy', "default-src 'none'")
292292
res.setHeader('X-Content-Type-Options', 'nosniff')
293293
res.end(doc)
294294
}
@@ -493,7 +493,7 @@ SendStream.prototype.redirect = function redirect (path) {
493493
res.statusCode = 301
494494
res.setHeader('Content-Type', 'text/html; charset=UTF-8')
495495
res.setHeader('Content-Length', Buffer.byteLength(doc))
496-
res.setHeader('Content-Security-Policy', "default-src 'self'")
496+
res.setHeader('Content-Security-Policy', "default-src 'none'")
497497
res.setHeader('X-Content-Type-Options', 'nosniff')
498498
res.setHeader('Location', loc)
499499
res.end(doc)

test/send.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ describe('send(file).pipe(res)', function () {
365365
request(createServer({ root: fixtures }))
366366
.get('/pets')
367367
.expect('Location', '/pets/')
368-
.expect('Content-Security-Policy', "default-src 'self'")
368+
.expect('Content-Security-Policy', "default-src 'none'")
369369
.expect(301, done)
370370
})
371371

@@ -400,7 +400,7 @@ describe('send(file).pipe(res)', function () {
400400
it('should respond with default Content-Security-Policy', function (done) {
401401
request(createServer({ root: fixtures }))
402402
.get('/foobar')
403-
.expect('Content-Security-Policy', "default-src 'self'")
403+
.expect('Content-Security-Policy', "default-src 'none'")
404404
.expect(404, done)
405405
})
406406

0 commit comments

Comments
 (0)