validation: arguments

Author: neelance

graphql.go

@@ -12,6 +12,7 @@ import (
 	"github.com/neelance/graphql-go/internal/exec"
 	"github.com/neelance/graphql-go/internal/query"
 	"github.com/neelance/graphql-go/internal/schema"
+	"github.com/neelance/graphql-go/internal/validation"
 	"github.com/neelance/graphql-go/introspection"
 )
 
@@ -116,11 +117,16 @@ func (s *Schema) Exec(ctx context.Context, queryString string, operationName str
 	}
 	defer span.Finish()
 
-	data, errs := exec.ExecuteRequest(subCtx, s.exec, document, operationName, variables, s.MaxParallelism)
-	if len(errs) != 0 {
-		ext.Error.Set(span, true)
-		span.SetTag(OpenTracingTagError, errs)
+	var data interface{}
+	errs := validation.Validate(s.schema, document)
+	if len(errs) == 0 {
+		data, errs = exec.ExecuteRequest(subCtx, s.exec, document, operationName, variables, s.MaxParallelism)
+		if len(errs) != 0 {
+			ext.Error.Set(span, true)
+			span.SetTag(OpenTracingTagError, errs)
+		}
 	}
+
 	return &Response{
 		Data:   data,
 		Errors: errs,

graphql_test.go

@@ -842,7 +842,7 @@ func TestMutation(t *testing.T) {
 			Schema: starwarsSchema,
 			Query: `
 				{
-					reviews(episode: "JEDI") {
+					reviews(episode: JEDI) {
 						stars
 						commentary
 					}
@@ -912,7 +912,7 @@ func TestMutation(t *testing.T) {
 			Schema: starwarsSchema,
 			Query: `
 				{
-					reviews(episode: "JEDI") {
+					reviews(episode: JEDI) {
 						stars
 						commentary
 					}
@@ -1532,8 +1532,7 @@ func TestInput(t *testing.T) {
 			Schema: coercionSchema,
 			Query: `
 				{
-					int1: int(value: 42)
-					int2: int(value: 42.0)
+					int(value: 42)
 					float1: float(value: 42)
 					float2: float(value: 42.5)
 					string(value: "foo")
@@ -1552,8 +1551,7 @@ func TestInput(t *testing.T) {
 			`,
 			ExpectedResult: `
 				{
-					"int1": 42,
-					"int2": 42,
+					"int": 42,
 					"float1": 42,
 					"float2": 42.5,
 					"string": "foo",

internal/tests/all_test.go

@@ -0,0 +1,59 @@
+package tests
+
+import (
+	"io/ioutil"
+	"os"
+	"reflect"
+	"testing"
+
+	"encoding/json"
+
+	"github.com/neelance/graphql-go/errors"
+	"github.com/neelance/graphql-go/internal/query"
+	"github.com/neelance/graphql-go/internal/schema"
+	"github.com/neelance/graphql-go/internal/validation"
+)
+
+type Test struct {
+	Name   string
+	Query  string
+	Errors []*errors.QueryError
+}
+
+func TestAll(t *testing.T) {
+	d, err := ioutil.ReadFile("testdata/test.schema")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	s := schema.New()
+	if err := s.Parse(string(d)); err != nil {
+		t.Fatal(err)
+	}
+
+	f, err := os.Open("testdata/tests.json")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	var tests []*Test
+	if err := json.NewDecoder(f).Decode(&tests); err != nil {
+		t.Fatal(err)
+	}
+
+	for _, test := range tests {
+		t.Run(test.Name, func(t *testing.T) {
+			d, err := query.Parse(test.Query)
+			if err != nil {
+				t.Error(err)
+			}
+			got := validation.Validate(s, d)
+			if got == nil {
+				got = []*errors.QueryError{}
+			}
+			if !reflect.DeepEqual(test.Errors, got) {
+				t.Errorf("wrong errors\nexpected: %v\ngot:      %v", test.Errors, got)
+			}
+		})
+	}
+}

internal/tests/testdata/LICENSE

@@ -0,0 +1,33 @@
+The files in this testdata directory are derived from the graphql-js project:
+https://github.com/graphql/graphql-js
+
+BSD License
+
+For GraphQL software
+
+Copyright (c) 2015, Facebook, Inc. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification,
+are permitted provided that the following conditions are met:
+
+ * Redistributions of source code must retain the above copyright notice, this
+   list of conditions and the following disclaimer.
+
+ * Redistributions in binary form must reproduce the above copyright notice,
+   this list of conditions and the following disclaimer in the documentation
+   and/or other materials provided with the distribution.
+
+ * Neither the name Facebook nor the names of its contributors may be used to
+   endorse or promote products derived from this software without specific
+   prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
+ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

internal/tests/testdata/test.schema

@@ -0,0 +1,140 @@
+schema {
+  query: QueryRoot
+}
+
+directive @onQuery on QUERY
+
+directive @onMutation on MUTATION
+
+directive @onSubscription on SUBSCRIPTION
+
+directive @onField on FIELD
+
+directive @onFragmentDefinition on FRAGMENT_DEFINITION
+
+directive @onFragmentSpread on FRAGMENT_SPREAD
+
+directive @onInlineFragment on INLINE_FRAGMENT
+
+directive @onSchema on SCHEMA
+
+directive @onScalar on SCALAR
+
+directive @onObject on OBJECT
+
+directive @onFieldDefinition on FIELD_DEFINITION
+
+directive @onArgumentDefinition on ARGUMENT_DEFINITION
+
+directive @onInterface on INTERFACE
+
+directive @onUnion on UNION
+
+directive @onEnum on ENUM
+
+directive @onEnumValue on ENUM_VALUE
+
+directive @onInputObject on INPUT_OBJECT
+
+directive @onInputFieldDefinition on INPUT_FIELD_DEFINITION
+
+type Alien implements Being, Intelligent {
+  iq: Int
+  name(surname: Boolean): String
+  numEyes: Int
+}
+
+interface Being {
+  name(surname: Boolean): String
+}
+
+interface Canine {
+  name(surname: Boolean): String
+}
+
+type Cat implements Being, Pet {
+  name(surname: Boolean): String
+  nickname: String
+  meows: Boolean
+  meowVolume: Int
+  furColor: FurColor
+}
+
+union CatOrDog = Dog | Cat
+
+input ComplexInput {
+  requiredField: Boolean!
+  intField: Int
+  stringField: String
+  booleanField: Boolean
+  stringListField: [String]
+}
+
+type ComplicatedArgs {
+  intArgField(intArg: Int): String
+  nonNullIntArgField(nonNullIntArg: Int!): String
+  stringArgField(stringArg: String): String
+  booleanArgField(booleanArg: Boolean): String
+  enumArgField(enumArg: FurColor): String
+  floatArgField(floatArg: Float): String
+  idArgField(idArg: ID): String
+  stringListArgField(stringListArg: [String]): String
+  complexArgField(complexArg: ComplexInput): String
+  multipleReqs(req1: Int!, req2: Int!): String
+  multipleOpts(opt1: Int = 0, opt2: Int = 0): String
+  multipleOptAndReq(req1: Int!, req2: Int!, opt1: Int = 0, opt2: Int = 0): String
+}
+
+type Dog implements Being, Pet, Canine {
+  name(surname: Boolean): String
+  nickname: String
+  barkVolume: Int
+  barks: Boolean
+  doesKnowCommand(dogCommand: DogCommand): Boolean
+  isHousetrained(atOtherHomes: Boolean = true): Boolean
+  isAtLocation(x: Int, y: Int): Boolean
+}
+
+enum DogCommand {
+  SIT
+  HEEL
+  DOWN
+}
+
+union DogOrHuman = Dog | Human
+
+enum FurColor {
+  BROWN
+  BLACK
+  TAN
+  SPOTTED
+}
+
+type Human implements Being, Intelligent {
+  name(surname: Boolean): String
+  pets: [Pet]
+  relatives: [Human]
+  iq: Int
+}
+
+union HumanOrAlien = Human | Alien
+
+interface Intelligent {
+  iq: Int
+}
+
+interface Pet {
+  name(surname: Boolean): String
+}
+
+type QueryRoot {
+  human(id: ID): Human
+  alien: Alien
+  dog: Dog
+  cat: Cat
+  pet: Pet
+  catOrDog: CatOrDog
+  dogOrHuman: DogOrHuman
+  humanOrAlien: HumanOrAlien
+  complicatedArgs: ComplicatedArgs
+}