Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray right-klick popup-menu is not aligned correctly () #2444

Open
erdnuesse opened this issue Sep 14, 2020 · 5 comments
Open

Tray right-klick popup-menu is not aligned correctly () #2444

erdnuesse opened this issue Sep 14, 2020 · 5 comments

Comments

@erdnuesse
Copy link

Steps to reproduce the problem

Use Windows version (didn't try others)
Right click on tray Icon

What's going on? Describe the problem in as much detail as possible.

Popup-menu is not aligned correctly.

Expectation: showing items starting from the top,
(Addition: if too many items, overflow with scroll-down button -> I expect this because - screenshot.)

Reality: Menu is always scrolled, removing top items, leaving unneeded space below.
Annotation 2020-09-14 125435
Annotation 2020-09-14 125813

Information about the software:

Deadbeef version: 1.8.4
OS: Win 10

@kuba160
Copy link
Member

kuba160 commented Sep 14, 2020

It is known bug, but nobody has found a way to fix it. As I remember @saivert was looking into it. I didn't work on that issue, as my gtk skills are weak. We suspected it might be some GTK issue as tray menu is working fine on other systems. I can only ask @Alexey-Yakovenko to look at the code and maybe find what causes this issue and/or give some ideas how to fix this.

@Oleksiy-Yakovenko
Copy link
Member

I can't remember where we discussed this the last time, but I think this is a GTK issue, and the same problem will happen with any GTK app which uses system tray / status notification icon + menu on windows.

@saivert
Copy link
Contributor

saivert commented Sep 14, 2020

I would try to replace the code and make use of the gtk_menu_popup_at_pointer API instead where GTK will handle positioning based on the current mouse pointer location. This is supposed to fix issues with use of gtk_menu_popup () which has been deprecated and isn't working right on e.g. Wayland where you cannot use absolute coordinate space. I'm sure something similar trips up GTK3 when the popup menu is spawned outside the context of a parent GTK window. That said the popup menu behaves oddly even on the GTK2 version.

Popup menus need to know where on the screen they should appear so they can avoid overflowing the monitor edge and so on.

I have not been able to test this myself though. Just giving some quick hints that I think maybe could work.

@Kissaki
Copy link

Kissaki commented Mar 6, 2024

The ticket description has the items scroll out at the top. That's opposite of what I see, and to a less severe degree.

Deadbeef version: 1.9.6
OS: Win 11

screenshot of deadbeef tray context menu showing only first two action items while having space for all
image

The space of the frame is enough; once I scroll all the way down through hover all items show up fine.

@Kissaki
Copy link

Kissaki commented Mar 6, 2024

Given that a GTK theme is used, could it be a theme issue or intersect with theme styling and layout rules?

Searching for 'tray' in DeaDBeeF\share\themes\Windows-10\ I'm not sure where to edit things. I tried removing some spacing in tint2rc and system-tray-collapsible.css but that didn't change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants