Skip to content

Move poetry specific to component #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 7, 2024
Merged

Conversation

DavidVujic
Copy link
Owner

@DavidVujic DavidVujic commented Jan 4, 2024

Description

Prepare for PEP 621 ready pyproject.toml files, used in tools like PDM and Hatch. Poetry currently does not support this standard, and uses its own format (i.e. tool.poetry for project metadata).

Motivation and Context

A first step towards supporting PDM (see #135)
and a first step towards supportingHatch (see #100)

How Has This Been Tested?

✅ Unit tests
✅ CI
✅ build and install local version and run the poly commands manually on the python-polylith-example repo.
✅ create a new workspace, bases and components with the poly commands. Run the diff, check, libs and sync commands.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic marked this pull request as ready for review January 6, 2024 16:57
Copy link

sonarqubecloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidVujic DavidVujic merged commit c60e57e into main Jan 7, 2024
@DavidVujic DavidVujic deleted the move-poetry-specific-to-component branch January 7, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant