added features to all biomes

Author: DavidQF555

src/main/java/multiverse/common/Multiverse.java

@@ -49,6 +49,7 @@ private void addRegistries(IEventBus bus) {
         BiomeSourceRegistry.SOURCES.register(bus);
         SurfaceRuleSourceRegistry.SOURCES.register(bus);
         EffectRegistry.EFFECTS.register(bus);
+        BiomeModifierRegistry.TYPES.register(bus);
 
         BiomeChunkGeneratorGeneratorTypeRegistry.TYPES.register(bus);
         BiomeDimensionGeneratorTypeRegistry.TYPES.register(bus);

src/main/java/multiverse/common/ServerConfigs.java

@@ -15,12 +15,12 @@ public class ServerConfigs {
     }
 
     public final ForgeConfigSpec.DoubleValue travelerSpawnChance, minRiftWidth, maxRiftWidth, fireworkRate, fireRate, minSpawnRadius, maxSpawnRadius, spawnOffset, swordMinWidth, swordMaxWidth, swordWidthRate, swordMinHeight, swordMaxHeight, swordHeightRate, swordSpawnDistance, coreRange, bountyRate, conquerorMinSpawnDist, conquerorMaxSpawnDist, conquerorMaxSpawnHDist, conquerorDistanceThreshold, shieldRange;
-        public final ForgeConfigSpec.IntValue riftRange, minRiftHeight, maxRiftHeight, spawnPeriod, spawnCount, slowFalling, swordMinCharge, swordCooldown, armorMinOffset, armorMaxOffset, armorMaxSpawn, armorSpawnPeriod, doppelTimeout, travelerMaxDoppel, travelerDoppelPeriod, travelerMinRange, travelerMaxRange, conquerorMobThreshold, conquerorCastTime, conquerorCooldown, conquerorSlowFallingDuration, conquerorSlowFallingAmplifier, conquerorSpawnCount, warpRingCooldown;
+    public final ForgeConfigSpec.IntValue riftRange, minRiftHeight, maxRiftHeight, spawnPeriod, spawnCount, slowFalling, swordMinCharge, swordCooldown, armorMinOffset, armorMaxOffset, armorMaxSpawn, armorSpawnPeriod, doppelTimeout, travelerMaxDoppel, travelerDoppelPeriod, travelerMinRange, travelerMaxRange, conquerorMobThreshold, conquerorCastTime, conquerorCooldown, conquerorSlowFallingDuration, conquerorSlowFallingAmplifier, conquerorSpawnCount, warpRingCooldown;
     public final ForgeConfigSpec.LongValue colorSeedOffset;
     public final ForgeConfigSpec.BooleanValue riftSwordTemporary, coreTemporary;
 
     public ServerConfigs(ForgeConfigSpec.Builder builder) {
-            builder.comment("Multiverse server-side configuration").push("Rifts");
+        builder.comment("Multiverse server-side configuration").push("Rifts");
         riftRange = builder.comment("This is the range that is scanned for existing rifts using points of interest. ")
                 .defineInRange("range", 128, 0, Integer.MAX_VALUE);
         colorSeedOffset = builder.comment("This is the factor that is added to the rift color seed. Change to modify all rift colors in the server. ")

src/main/java/multiverse/common/world/worldgen/biomes/AddFeaturesAllBiomeModifier.java

@@ -0,0 +1,35 @@
+package multiverse.common.world.worldgen.biomes;
+
+import com.mojang.serialization.Codec;
+import com.mojang.serialization.codecs.RecordCodecBuilder;
+import net.minecraft.core.Holder;
+import net.minecraft.core.HolderSet;
+import net.minecraft.world.level.biome.Biome;
+import net.minecraft.world.level.levelgen.GenerationStep;
+import net.minecraft.world.level.levelgen.placement.PlacedFeature;
+import net.minecraftforge.common.world.BiomeGenerationSettingsBuilder;
+import net.minecraftforge.common.world.BiomeModifier;
+import net.minecraftforge.common.world.ModifiableBiomeInfo;
+
+public record AddFeaturesAllBiomeModifier(HolderSet<PlacedFeature> features,
+                                          GenerationStep.Decoration step) implements BiomeModifier {
+
+    public static final Codec<AddFeaturesAllBiomeModifier> CODEC = RecordCodecBuilder.create(inst -> inst.group(
+            PlacedFeature.LIST_CODEC.fieldOf("features").forGetter(AddFeaturesAllBiomeModifier::features),
+            GenerationStep.Decoration.CODEC.fieldOf("step").forGetter(AddFeaturesAllBiomeModifier::step)
+    ).apply(inst, AddFeaturesAllBiomeModifier::new));
+
+    @Override
+    public void modify(Holder<Biome> biome, Phase phase, ModifiableBiomeInfo.BiomeInfo.Builder builder) {
+        if (phase == Phase.ADD) {
+            BiomeGenerationSettingsBuilder settings = builder.getGenerationSettings();
+            features().forEach(holder -> settings.addFeature(step(), holder));
+        }
+    }
+
+    @Override
+    public Codec<? extends AddFeaturesAllBiomeModifier> codec() {
+        return null;
+    }
+
+}

src/main/java/multiverse/registration/worldgen/BiomeModifierRegistry.java

@@ -0,0 +1,26 @@
+package multiverse.registration.worldgen;
+
+import com.mojang.serialization.Codec;
+import multiverse.common.Multiverse;
+import multiverse.common.world.worldgen.biomes.AddFeaturesAllBiomeModifier;
+import net.minecraftforge.common.world.BiomeModifier;
+import net.minecraftforge.registries.DeferredRegister;
+import net.minecraftforge.registries.ForgeRegistries;
+import net.minecraftforge.registries.RegistryObject;
+
+import java.util.function.Supplier;
+
+public final class BiomeModifierRegistry {
+
+    public static final DeferredRegister<Codec<? extends BiomeModifier>> TYPES = DeferredRegister.create(ForgeRegistries.Keys.BIOME_MODIFIER_SERIALIZERS, Multiverse.MOD_ID);
+
+    public static final RegistryObject<Codec<AddFeaturesAllBiomeModifier>> ADD_ALL = register("add_features_all", () -> AddFeaturesAllBiomeModifier.CODEC);
+
+    private BiomeModifierRegistry() {
+    }
+
+    private static <T extends BiomeModifier> RegistryObject<Codec<T>> register(String name, Supplier<Codec<T>> codec) {
+        return TYPES.register(name, codec);
+    }
+
+}

src/main/resources/data/multiverse/forge/biome_modifier/kaleidite_cluster.json

@@ -1,6 +1,5 @@
 {
-  "type": "forge:add_features",
-  "biomes": "#multiverse:multiverse",
+  "type": "multiverse:add_features_all",
   "features": "multiverse:kaleidite_cluster",
   "step": "local_modifications"
 }

src/main/resources/data/multiverse/forge/biome_modifier/rift.json

@@ -1,6 +1,5 @@
 {
-  "type": "forge:add_features",
-  "biomes": "#multiverse:multiverse",
+  "type": "multiverse:add_features_all",
   "features": "multiverse:rift",
   "step": "local_modifications"
 }