Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance of PosteriorPredictiveModel for PredictivePopulationModel is very slow #167

Open
DavAug opened this issue Feb 11, 2021 · 1 comment

Comments

@DavAug
Copy link
Owner

DavAug commented Feb 11, 2021

Investigate why that is

  1. Because random number generator is instantiated multiple times?
  2. The way dataframe is created?

Start by comparing perfomance of PredictivePopulationModel and PosteriorPredictiveModel

@DavAug
Copy link
Owner Author

DavAug commented Feb 15, 2021

It is not the RNG, also the new implementation might speed up things anyway. It seems that the execution time grows exponentially with the number of samples, this might suggest that it's the appending of the rather small chunks of dataframes.

So it may be resolved when we move to xarrays for the sample output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant