Merge pull request #18 from souza-dan/s3-bucket-rule

DEV-15177 - ignore changes to rules within the bucket resource

Author: souza-dan

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Tamr S3 Module Repo
 
+## v1.3.2 - August 9th 2022
+* Fixes a bug where two resources were controlling server side encryption
+
 ## v1.3.1 - August 4th 2022
 * Adjusts AWS provider constraints to allow newer versions
 

VERSION

@@ -1 +1 @@
-1.3.1
+1.3.2

examples/iam-policy-submodule/main.tf

@@ -4,15 +4,15 @@ data "aws_s3_bucket" "existing-bucket" {
 }
 
 module "existing-bucket-iam-0" {
-  # source = "git::https://github.com/Datatamer/terraform-aws-s3.git//modules/bucket-iam-policy?ref=1.2.1"
+  # source = "git::https://github.com/Datatamer/terraform-aws-s3.git//modules/bucket-iam-policy?ref=1.3.2"
   source           = "../../modules/bucket-iam-policy"
   bucket_name      = data.aws_s3_bucket.existing-bucket.id
   read_write_paths = ["some/read-write-folder"]
   tags             = var.tags
 }
 
 module "existing-bucket-iam-1" {
-  # source = "git::https://github.com/Datatamer/terraform-aws-s3.git//modules/bucket-iam-policy?ref=1.2.1"
+  # source = "git::https://github.com/Datatamer/terraform-aws-s3.git//modules/bucket-iam-policy?ref=1.3.2"
   source           = "../../modules/bucket-iam-policy"
   bucket_name      = data.aws_s3_bucket.existing-bucket.id
   read_write_paths = ["another/read-write-folder"]

examples/minimal/main.tf

@@ -1,5 +1,5 @@
 module "minimal" {
-  # source           = "git::https://github.com/Datatamer/terraform-aws-s3?ref=1.2.1"
+  # source           = "git::https://github.com/Datatamer/terraform-aws-s3?ref=1.3.2"
   source            = "../../"
   bucket_name       = var.test_bucket_name
   read_only_paths   = var.read_only_paths  # ["path/to/ro-folder"]

modules/encrypted-bucket/main.tf

@@ -5,6 +5,13 @@ resource "aws_s3_bucket" "new_bucket" {
 
   force_destroy = var.force_destroy
   tags          = var.tags
+
+  # Managed by resource below
+  lifecycle {
+    ignore_changes = [
+      server_side_encryption_configuration,
+    ]
+  }
 }
 
 resource "aws_s3_bucket_server_side_encryption_configuration" "encryption_for_new_bucket" {