Improve consistency by using response from POST/PUT requests directly to save state #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therve
requested changes
Feb 15, 2021
datadog/resource_datadog_role.go
Outdated
| switch rolePerms := rolePermsI.(type) { | ||
| case []datadog.RelationshipToPermissionData: | ||
| for _, permI := range rolePerms { | ||
| perms = appendPerm(perms, &permI, permsIDToName) |
There was a problem hiding this comment.
I think you can just pass permI.GetId(), this will simplify the code in appendPerm.
There was a problem hiding this comment.
True, thanks for the suggestion
therve
previously approved these changes
Feb 15, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
force-pushed
the
hippo/rolesredo
branch
from
8ec31a0 to
5b2237d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
therve
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid consistency issues, due to replication delays, caused by calling the GET endpoint right after POST/PUT