Deprecate TypeMap field in synthetics #870
Conversation
| Elem: syntheticsTestRequest(), | ||
| }, | ||
| "request_definition": { | ||
| Description: "The synthetics test request. Required if `type = \"api\"` and `subtype = \"http\"`.", |
There was a problem hiding this comment.
This part may be legacy but Required if type = "api" and subtype = "http". is not true, it should be just Required if type = "api"
| timeoutInt, _ := strconv.Atoi(attr.(string)) | ||
| if attr, ok := k.GetOkWith("timeout"); ok { | ||
| var timeoutInt int | ||
| // first try to convert to int if we're getting from the new TypeList field |
There was a problem hiding this comment.
Sanity checking; is this because everything in a TypeMap is a string, regardless of what the Type is set as?
| @@ -30,33 +30,6 @@ func TestAccDatadogSyntheticsAPITest_importBasic(t *testing.T) { | |||
| ResourceName: "datadog_synthetics_test.foo", | |||
| ImportState: true, | |||
| ImportStateVerify: true, | |||
| // Assertions will be imported into the new schema by default, but we can ignore them as users need to update the local config in this case | |||
| ImportStateVerifyIgnore: []string{"assertions", "assertion", "options", "options_list"}, | |||
There was a problem hiding this comment.
We want verification on these fields
| }) | ||
| } | ||
|
|
||
| func TestAccDatadogSyntheticsAPITest_importBasicNewAssertionsOptions(t *testing.T) { |
There was a problem hiding this comment.
Are we covering this import elsewhere?
There was a problem hiding this comment.
Deprecated field cannot be imported, as the implementation of read prefers the new fields when not set in config (which is the case for import)
I modified the main test config to not have any deprecated fields in it, so the other import tests now does the proper verifications (without the importIgnore)
This one is then rendered useless, as it's just a duplication
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
deprecate typeMap
requestin favor of typeListrequest_definition