Merge pull request #433 from DataObjects-NET/master-remove-obsoletes

Remove obsolete members that was marked so in 7.1 or earlier

Author: alex-kulakov

ChangeLog/7.2.0-Beta-2-dev.txt

@@ -1,5 +1,9 @@
 [main] Upgrade hints change names of constructors' string parameters for better understanding of what suppose to be in them.
 [main] Improved string operations Trim/TrimStart/TrimEnd support
+[main] Obsolete DomainConfiguration.DefauktForeignKeyMode const removed, the correctly named constant still exists
+[main] Obsolete SqlPersistTask constructors removed
+[main] Obsolete AggregateProvider constructor removed
+[main] Obsolete CalculateProvider constructor removed
 [mysql] SqlDml.NullIf function now correctly translated
 [mysql] Improved support for string.PadLeft/PadRight opertaions
 [sqlite] Fixed string.Lenght translation

Orm/Xtensive.Orm/Orm/Configuration/DomainConfiguration.cs

@@ -86,12 +86,6 @@ public class DomainConfiguration : ConfigurationBase
     /// </summary>
     public const DomainUpgradeMode DefaultUpgradeMode = DomainUpgradeMode.Default;
 
-    /// <summary>
-    /// Default <see cref="ForeignKeyMode"/> value.
-    /// </summary>
-    [Obsolete ("User DefaultForeignKeyMode")]
-    public const ForeignKeyMode DefauktForeignKeyMode = ForeignKeyMode.Default;
-
     /// <summary>
     /// Default <see cref="ForeignKeyMode"/> value.
     /// </summary>

Orm/Xtensive.Orm/Orm/Providers/CommandProcessing/SqlPersistTask.cs

@@ -69,18 +69,6 @@ public SqlPersistTask(PersistRequest request, IReadOnlyList<Tuple> tuples)
       Tuples = tuples;
     }
 
-    [Obsolete]
-    public SqlPersistTask(Key key, IEnumerable<PersistRequest> requestSequence, Tuple tuple)
-      : this(key, (requestSequence as IReadOnlyCollection<PersistRequest>)?? requestSequence.ToList(), tuple)
-    {
-    }
-
-    [Obsolete]
-    public SqlPersistTask(Key key, IEnumerable<PersistRequest> requestSequence, Tuple tuple, Tuple originalTuple, bool validateRowCount)
-      : this(key, (requestSequence as IReadOnlyCollection<PersistRequest>) ?? requestSequence.ToList(), tuple, originalTuple, validateRowCount)
-    {
-    }
-
     public SqlPersistTask(Key key, IReadOnlyCollection<PersistRequest> requestSequence, Tuple tuple)
     {
       EntityKey = key;

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/AggregateProvider.cs

@@ -190,18 +190,6 @@ private static NotSupportedException AggregateNotSupported(Type sourceColumnType
 
     // Constructors
 
-    /// <summary>
-    /// Initializes a new instance of this class.
-    /// </summary>
-    /// <param name="source">The <see cref="UnaryProvider.Source"/> property value.</param>
-    /// <param name="groupIndexes">The column indexes to group by.</param>
-    /// <param name="columnDescriptors">The descriptors of <see cref="AggregateColumns"/>.</param>
-    [Obsolete]
-    public AggregateProvider(CompilableProvider source, int[] groupIndexes, params AggregateColumnDescriptor[] columnDescriptors)
-      : this(source, groupIndexes, (IReadOnlyList<AggregateColumnDescriptor>) columnDescriptors)
-    {
-    }
-
     /// <summary>
     /// Initializes a new instance of this class.
     /// </summary>

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/CalculateProvider.cs

@@ -61,37 +61,6 @@ protected override void Initialize()
 
     // Constructors
 
-    /// <summary>
-    /// Initializes a new instance of this class.
-    /// </summary>
-    /// <param name="source">The <see cref="UnaryProvider.Source"/> property value.</param>
-    /// <param name="columnDescriptors">The descriptors of <see cref="CalculatedColumns"/>.</param>
-    [Obsolete]
-    public CalculateProvider(CompilableProvider source, params CalculatedColumnDescriptor[] columnDescriptors)
-      : this(source, false, columnDescriptors)
-    {
-    }
-
-    /// <summary>
-    /// 	Initializes a new instance of this class.
-    /// </summary>
-    /// <param name="source">The <see cref="UnaryProvider.Source"/> property value.</param>
-    /// <param name="isInlined">The <see cref="IsInlined"/> property value.</param>
-    /// <param name="columnDescriptors">The descriptors of <see cref="CalculatedColumns"/>.</param>
-    [Obsolete]
-    public CalculateProvider(CompilableProvider source, bool isInlined, params CalculatedColumnDescriptor[] columnDescriptors)
-      : base(ProviderType.Calculate, source)
-    {
-      IsInlined = isInlined;
-      var columns = new CalculatedColumn[columnDescriptors.Length];
-      for (int i = 0; i < columnDescriptors.Length; i++) {
-        var col = new CalculatedColumn(columnDescriptors[i], Source.Header.Length + i);
-        columns.SetValue(col, i);
-      }
-      CalculatedColumns = columns;
-      Initialize();
-    }
-
     /// <summary>
     /// Initializes a new instance of this class.
     /// </summary>