Switch DJ API to Pydantic v2 #1509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
pydanticv2-upgrade
branch
5 times, most recently
from
bc56e2f to
a9ce05f
Compare
shangyian
changed the title
shangyian
force-pushed
the
pydanticv2-upgrade
branch
from
a9ce05f to
49ba53b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've needed to upgrade to Pydantic v2 for some time. It should be significantly faster than v1, although it is worth benchmarking to make sure. This migration blocks various things downstream, including setting up an MCP server for DJ.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan