Idle samples should be kept to correctly estimate sampling period

Author: nsavoire

bindings/profilers/wall.cc

@@ -301,15 +301,6 @@ class ProfileTranslator {
   }
 };
 
-bool isIdleSample(const CpuProfileNode* sample) {
-  return
-#if NODE_MODULE_VERSION > NODE_12_0_MODULE_VERSION
-      sample->GetParent() == nullptr &&
-#endif
-      sample->GetChildrenCount() == 0 &&
-      strncmp("(idle)", sample->GetFunctionNameStr(), 7) == 0;
-}
-
 LabelSetsByNode WallProfiler::GetLabelSetsByNode(CpuProfile* profile,
                                                  ContextBuffer& contexts) {
   LabelSetsByNode labelSetsByNode;
@@ -350,10 +341,6 @@ LabelSetsByNode WallProfiler::GetLabelSetsByNode(CpuProfile* profile,
     auto sampleIdx = i + deltaIdx;
     auto sample = profile->GetSample(sampleIdx);
 
-    if (isIdleSample(sample)) {
-      continue;
-    }
-
     auto sampleTimestamp = profile->GetSampleTimestamp(sampleIdx);
 
     // This loop will drop all contexts that are too old to be associated with

ts/test/test-time-profiler.ts

@@ -120,6 +120,8 @@ describe('Time Profiler', () => {
           stringTable.dedup(x)
         );
 
+        assert(profile.period >= intervalNanos);
+        assert(profile.period < 2 * intervalNanos);
         function labelIs(l: Label, str: number) {
           return l.key === labelIdx && l.str === str;
         }