-
Notifications
You must be signed in to change notification settings - Fork 13
Add ddsketch to windows features list. #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ekump/APMSP-2151-create-ddsketch-ffi-crate
Are you sure you want to change the base?
Add ddsketch to windows features list. #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguably, Ruby is the first (and only) consumer for this, so we could omit it until actually someone else wants this, since we don't support windows on Ruby libdatadog builds anyway.
E.g. we could add this at any point in time, so I think we could delay it until we need it.
BenchmarksComparisonBenchmark execution time: 2025-07-10 15:47:08 Comparing candidate commit f1ccb68 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ekump/APMSP-2151-create-ddsketch-ffi-crate #1138 +/- ##
===========================================================================
Coverage 71.27% 71.28%
===========================================================================
Files 346 346
Lines 52611 52611
===========================================================================
+ Hits 37501 37505 +4
+ Misses 15110 15106 -4
🚀 New features to boost your workflow:
|
What does this PR do?
Release ddsketch on windows builds.