Skip to content

Commit 7540423

Browse files
authored
Remove wildcard from CODEOWNERS and ensure all files are properly owned (#1284)
cleanup CODEOWNERS - remove catchall cleanup CODEOWNERS - add lint action to verify file cleanup CODEOWNERS - assign teams to all files cleanup CODEOWNERS - organize and format file Co-authored-by: edmund.kump <edmund.kump@datadoghq.com>
1 parent 0808f16 commit 7540423

File tree

2 files changed

+92
-29
lines changed

2 files changed

+92
-29
lines changed

.github/CODEOWNERS

Lines changed: 71 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,72 @@
1-
* @Datadog/libdatadog-core
2-
libdd-alloc/ @Datadog/libdatadog-profiling
3-
libdd-crashtracking*/ @Datadog/libdatadog-profiling
4-
libdd-profiling*/ @Datadog/libdatadog-profiling
5-
libdd-telemetry*/ @Datadog/libdatadog-telemetry
6-
ruby/ @Datadog/ruby-guild
7-
Cargo.* @Datadog/libdatadog
8-
.gitignore @Datadog/libdatadog
9-
.gitlab-ci.yaml @Datadog/libdatadog
10-
LICENSE* @Datadog/libdatadog
11-
NOTICE @Datadog/libdatadog
12-
rustfmt.toml @Datadog/libdatadog
13-
README.md @Datadog/libdatadog
14-
libdd-trace-normalization @Datadog/serverless @Datadog/libdatadog-apm
15-
datadog-trace-obfuscation @Datadog/serverless @Datadog/libdatadog-apm
16-
libdd-trace-protobuf @Datadog/serverless @Datadog/libdatadog-apm
17-
libdd-trace-utils @Datadog/serverless @Datadog/libdatadog-apm
18-
datadog-remote-config @Datadog/libdatadog-php @Datadog/libdatadog-apm @Datadog/remote-config
19-
datadog-sidecar @Datadog/libdatadog-php @Datadog/libdatadog-apm
20-
datadog-sidecar-ffi @Datadog/libdatadog-php @Datadog/libdatadog-apm
21-
libdd-data-pipeline*/ @Datadog/libdatadog-apm
22-
datadog-tracer-flare @Datadog/libdatadog-apm
23-
libdd-ddsketch*/ @Datadog/libdatadog-apm @Datadog/libdatadog-telemetry
24-
datadog-ffe @Datadog/feature-flagging-and-experimentation-sdk
25-
datadog-ffe-ffi @Datadog/feature-flagging-and-experimentation-sdk
1+
# CODEOWNERS
2+
# Rules are evaluated in order. Later matches override earlier ones.
3+
# More specific patterns at the bottom override general patterns above.
264

27-
# Most of the bin_tests are owned by the profiling team, but some are owned by the core team
28-
bin_tests/ @Datadog/libdatadog-profiling
29-
bin_tests/tests/test_the_tests.rs @Datadog/libdatadog-core
30-
bin_tests/src/bin/test_the_tests.rs @Datadog/libdatadog-core
5+
.clang-format @Datadog/libdatadog
6+
.codecov.yml @Datadog/apm-common-components-core
7+
.config/nextest.toml @Datadog/apm-common-components-core
8+
.devcontainer @Datadog/apm-common-components-core
9+
.dockerignore @Datadog/libdatadog-core
10+
.github/ @Datadog/apm-common-components-core
11+
.gitignore @Datadog/libdatadog
12+
.gitlab-ci.yml @Datadog/apm-common-components-core
13+
.gitlab/benchmarks.yml @Datadog/apm-common-components-core
14+
benchmark/ @Datadog/apm-common-components-core
15+
bin_tests/ @Datadog/libdatadog-profiling
16+
build-common/ @Datadog/apm-common-components-core
17+
builder @Datadog/apm-common-components-core
18+
Cargo.* @Datadog/libdatadog
19+
cmake/ @Datadog/apm-common-components-core
20+
CONTRIBUTING.md @Datadog/libdatadog-core
21+
Cross.toml @Datadog/apm-common-components-core
22+
datadog-ffe @Datadog/feature-flagging-and-experimentation-sdk
23+
datadog-ffe-ffi @Datadog/feature-flagging-and-experimentation-sdk
24+
datadog-ipc*/ @Datadog/libdatadog-php
25+
datadog-live-debugger*/ @Datadog/libdatadog-php @Datadog/libdatadog-apm
26+
datadog-profiling-replayer @Datadog/libdatadog-profiling
27+
datadog-remote-config @Datadog/libdatadog-php @Datadog/libdatadog-apm @Datadog/remote-config
28+
datadog-sidecar @Datadog/libdatadog-php @Datadog/libdatadog-apm
29+
datadog-sidecar-ffi @Datadog/libdatadog-php @Datadog/libdatadog-apm
30+
datadog-sidecar-macros @Datadog/libdatadog-php
31+
datadog-trace-obfuscation @Datadog/serverless @Datadog/libdatadog-apm
32+
datadog-tracer-flare @Datadog/libdatadog-apm
33+
docker-bake.hcl @Datadog/apm-common-components-core
34+
docs @Datadog/libdatadog
35+
examples @Datadog/libdatadog
36+
libdd-alloc/ @Datadog/libdatadog-profiling
37+
libdd-common*/ @Datadog/libdatadog
38+
libdd-crashtracker*/ @Datadog/libdatadog-profiling
39+
libdd-data-pipeline*/ @Datadog/libdatadog-apm
40+
libdd-ddsketch*/ @Datadog/libdatadog-apm @Datadog/apm-common-components-core
41+
libdd-dogstatsd-client @Datadog/apm-common-components-core
42+
libdd-library-config*/ @Datadog/apm-sdk-capabilities
43+
libdd-log*/ @Datadog/apm-common-components-core
44+
libdd-profiling*/ @Datadog/libdatadog-profiling
45+
libdd-telemetry*/ @Datadog/apm-common-components-core
46+
libdd-tinybytes @Datadog/apm-common-components-core
47+
libdd-trace-normalization @Datadog/serverless @Datadog/libdatadog-apm
48+
libdd-trace-protobuf @Datadog/serverless @Datadog/libdatadog-apm
49+
libdd-trace-stats @Datadog/apm-common-components-core
50+
libdd-trace-utils @Datadog/serverless @Datadog/libdatadog-apm
51+
LICENSE* @Datadog/libdatadog
52+
local-linux.Dockerfile @Datadog/libdatadog
53+
NOTICE @Datadog/libdatadog
54+
README.md @Datadog/libdatadog
55+
repository.datadog.yml @Datadog/apm-common-components-core
56+
ruby/ @Datadog/ruby-guild
57+
rustfmt.toml @Datadog/libdatadog-core
58+
scripts/reformat_copyright.sh @Datadog/libdatadog-core
59+
scripts/update_license_3rdparty.sh @Datadog/libdatadog-core
60+
spawn_worker/ @Datadog/libdatadog-php @Datadog/libdatadog-apm
61+
symbolizer-ffi @Datadog/libdatadog-profiling
62+
tests/run-package-tests.ps1 @Datadog/apm-common-components-core
63+
tests/spawn_from_lib/ @Datadog/libdatadog-php @Datadog/libdatadog-apm
64+
tests/windows_package/ @Datadog/apm-common-components-core
65+
tools/ @Datadog/apm-common-components-core
66+
windows/ @Datadog/libdatadog-core
67+
68+
# Specific overrides (must come after their general patterns above)
69+
bin_tests/tests/test_the_tests.rs @Datadog/libdatadog-core
70+
bin_tests/src/bin/test_the_tests.rs @Datadog/libdatadog-core
71+
tools/cc_utils/ @Datadog/libdatadog-php
72+
tools/sidecar_mockgen/ @Datadog/libdatadog-php

.github/workflows/lint.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,3 +133,24 @@ jobs:
133133
name: LICENSE-3rdparty.yml
134134
path: /tmp/CI.yaml
135135
overwrite: true
136+
137+
codeowners-validator:
138+
runs-on: ubuntu-latest
139+
name: "Validate CODEOWNERS"
140+
steps:
141+
- name: Checkout sources
142+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
143+
- name: GitHub CODEOWNERS Validator
144+
uses: mszostok/codeowners-validator@7f3f5e28c6d7b8dfae5731e54ce2272ca384592f #v0.7.4
145+
# input parameters
146+
with:
147+
github_app_id: ${{ secrets.CODEOWNERS_VALIDATOR_APP_ID }}
148+
github_app_installation_id: ${{ secrets.CODEOWNERS_VALIDATOR_APP_INSTALLATION_ID }}
149+
github_app_private_key: ${{ secrets.CODEOWNERS_VALIDATOR_APP_PRIVATE_KEY }}
150+
151+
# "The list of checks that will be executed. By default, all checks are executed. Possible values: files,owners,duppatterns,syntax"
152+
checks: "files,duppatterns,syntax"
153+
# "The comma-separated list of experimental checks that should be executed. By default, all experimental checks are turned off. Possible values: notowned."
154+
experimental_checks: "notowned"
155+
# The repository path in which CODEOWNERS file should be validated."
156+
repository_path: "."

0 commit comments

Comments
 (0)