[Versioning] Crashtracker (#1321)

Rename ddtelemetry and ddtelemetry-ffi

Fix FFI tests

Try to fix package_ffi_on_windows gitlab job

Rename ddcommon and ddcommon-ffi

windows fix

Fix crashtracker cbindgen.

Merge branch 'igor/versioning/libdd-telemetry' into igor/versioning/libdd-common

fully update the ddcommon and ddcommon-ffi dependencies to reflect the new libdd prefix

Merge remote-tracking branch 'origin/main' into igor/versioning/libdd-common

Add missing version

Rename crashtracker and crashtracker-ffi.

Fix compilation.

Fix build.

Fix lint.

Fix tests.

Fix workflows.

Change libddprog-build branch to execute jobs.

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Merge branch 'main' into julio/versioning/crashtracker

Restore data-pipeline-ffi feature of datadog-profiling-ffi

Restore data-pipeline-ffi feature of datadog-profiling-ffi

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

fix libdd-common-ffi import in libdd-telemetry-ffi

fix formatting

update license file

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Co-authored-by: ekump <edmund.kump@datadoghq.com>
Co-authored-by: iunanua <igor.unanua@datadoghq.com>

Author: 3 people

.github/labeler.yml

@@ -59,6 +59,6 @@ data-pipeline:
 crashtracker:
 - changed-files:
   - any-glob-to-any-file: [
-    'datadog-crashtracker/**/*',
-    'datadog-crashtracker-ffi/**/*',
+    'libdd-crashtracker/**/*',
+    'libdd-crashtracker-ffi/**/*',
   ]

.github/workflows/test.yml

@@ -51,16 +51,16 @@ jobs:
       - name: "[${{ steps.rust-version.outputs.version}}] cargo build --workspace --exclude builder --verbose"
         shell: bash
         run: cargo build --workspace --exclude builder --verbose
-      - name: "[${{ steps.rust-version.outputs.version}}] cargo nextest run --workspace --features datadog-crashtracker/generate-unit-test-files --exclude builder --profile ci --verbose -E '!test(tracing_integration_tests::)'"
+      - name: "[${{ steps.rust-version.outputs.version}}] cargo nextest run --workspace --features libdd-crashtracker/generate-unit-test-files --exclude builder --profile ci --verbose -E '!test(tracing_integration_tests::)'"
         shell: bash
         # Run doc tests with cargo test and run tests with nextest and generate junit.xml
-        run: cargo test --workspace --features datadog-crashtracker/generate-unit-test-files --exclude builder --doc --verbose && cargo nextest run --workspace --features datadog-crashtracker/generate-unit-test-files --exclude builder --profile ci --verbose -E '!test(tracing_integration_tests::)'
+        run: cargo test --workspace --features libdd-crashtracker/generate-unit-test-files --exclude builder --doc --verbose && cargo nextest run --workspace --features libdd-crashtracker/generate-unit-test-files --exclude builder --profile ci --verbose -E '!test(tracing_integration_tests::)'
         env:
           RUST_BACKTRACE: full
-      - name: "[${{ steps.rust-version.outputs.version}}] Tracing integration tests: cargo nextest run --workspace --features datadog-crashtracker/generate-unit-test-files --exclude builder --profile ci --test-threads=1 --verbose -E 'test(tracing_integration_tests::)'"
+      - name: "[${{ steps.rust-version.outputs.version}}] Tracing integration tests: cargo nextest run --workspace --features libdd-crashtracker/generate-unit-test-files --exclude builder --profile ci --test-threads=1 --verbose -E 'test(tracing_integration_tests::)'"
         if: runner.os == 'Linux'
         shell: bash
-        run: cargo nextest run --workspace --features datadog-crashtracker/generate-unit-test-files --exclude builder --profile ci --test-threads=1 --verbose -E 'test(tracing_integration_tests::)'
+        run: cargo nextest run --workspace --features libdd-crashtracker/generate-unit-test-files --exclude builder --profile ci --test-threads=1 --verbose -E 'test(tracing_integration_tests::)'
         env:
           RUST_BACKTRACE: full
       - name: "[${{ steps.rust-version.outputs.version}}] RUSTFLAGS=\"-C prefer-dynamic\" cargo nextest run --package test_spawn_from_lib --features prefer-dynamic -E '!test(tracing_integration_tests::)'"
@@ -225,8 +225,8 @@ jobs:
           rust_version: cross-centos7
       - run: cargo install cross || true
       - run: cross build --workspace --target x86_64-unknown-linux-gnu --exclude builder
-      - run: cross test --workspace --features datadog-crashtracker/generate-unit-test-files --target x86_64-unknown-linux-gnu --exclude builder  -- --skip "::single_threaded_tests::" --skip "tracing_integration_tests::"
-      - run: cross test --workspace --features datadog-crashtracker/generate-unit-test-files --target x86_64-unknown-linux-gnu --exclude builder --exclude bin_tests -- --skip "::tests::" --skip "::api_tests::" --test-threads 1 --skip "tracing_integration_tests::"
+      - run: cross test --workspace --features libdd-crashtracker/generate-unit-test-files --target x86_64-unknown-linux-gnu --exclude builder  -- --skip "::single_threaded_tests::" --skip "tracing_integration_tests::"
+      - run: cross test --workspace --features libdd-crashtracker/generate-unit-test-files --target x86_64-unknown-linux-gnu --exclude builder --exclude bin_tests -- --skip "::tests::" --skip "::api_tests::" --test-threads 1 --skip "tracing_integration_tests::"
 
   ffi_bake:
     strategy:

.gitlab-ci.yml

@@ -2,7 +2,7 @@ variables:
   # These are gitlab variables so that it's easier to do a manual deploy
   # If these are set witih value and description, then it gives you UI elements
   DOWNSTREAM_BRANCH:
-    value: "main"
+    value: "julio/versioning/fix-crashtracker-feature"
     description: "downstream jobs are triggered on this branch"
 
 include:

Cargo.lock

@@ -5,8 +5,8 @@
 members = [
   "builder",
   "libdd-alloc",
-  "datadog-crashtracker",
-  "datadog-crashtracker-ffi",
+  "libdd-crashtracker",
+  "libdd-crashtracker-ffi",
   "datadog-ffe",
   "datadog-ffe-ffi",
   "datadog-ipc",

Cargo.toml

@@ -1,4 +1,4 @@
-root_name: builder, build_common, tools, libdd-alloc, datadog-crashtracker, libdd-common, libdd-telemetry, libdd-ddsketch, datadog-crashtracker-ffi, libdd-common-ffi, datadog-ffe, datadog-ffe-ffi, datadog-ipc, datadog-ipc-macros, libdd-tinybytes, tarpc, tarpc-plugins, spawn_worker, cc_utils, libdd-library-config, libdd-library-config-ffi, datadog-live-debugger, datadog-live-debugger-ffi, datadog-profiling, libdd-profiling-protobuf, datadog-profiling-ffi, libdd-data-pipeline-ffi, libdd-data-pipeline, libdd-dogstatsd-client, libdd-trace-protobuf, libdd-trace-stats, libdd-trace-utils, libdd-trace-normalization, libdd-log, libdd-ddsketch-ffi, libdd-log-ffi, libdd-telemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, datadog-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib
+root_name: builder, build_common, tools, libdd-alloc, libdd-crashtracker, libdd-common, libdd-telemetry, libdd-ddsketch, libdd-crashtracker-ffi, libdd-common-ffi, datadog-ffe, datadog-ffe-ffi, datadog-ipc, datadog-ipc-macros, libdd-tinybytes, tarpc, tarpc-plugins, spawn_worker, cc_utils, libdd-library-config, libdd-library-config-ffi, datadog-live-debugger, datadog-live-debugger-ffi, datadog-profiling, libdd-profiling-protobuf, datadog-profiling-ffi, libdd-data-pipeline-ffi, libdd-data-pipeline, libdd-dogstatsd-client, libdd-trace-protobuf, libdd-trace-stats, libdd-trace-utils, libdd-trace-normalization, libdd-log, libdd-ddsketch-ffi, libdd-log-ffi, libdd-telemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, datadog-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib
 third_party_libraries:
 - package_name: addr2line
   package_version: 0.24.2
@@ -27693,9 +27693,9 @@ third_party_libraries:
 - package_name: stringmetrics
   package_version: 2.2.2
   repository: https://github.com/pluots/stringmetrics
-  license: License specified in file ($CARGO_HOME/registry/src/index.crates.io-1949cf8c6b5b557f/stringmetrics-2.2.2/LICENSE)
+  license: License specified in file ($CARGO_HOME/registry/src/index.crates.io-6f17d22bba15001f/stringmetrics-2.2.2/LICENSE)
   licenses:
-  - license: License specified in file ($CARGO_HOME/registry/src/index.crates.io-1949cf8c6b5b557f/stringmetrics-2.2.2/LICENSE)
+  - license: License specified in file ($CARGO_HOME/registry/src/index.crates.io-6f17d22bba15001f/stringmetrics-2.2.2/LICENSE)
     text: |
       Copyright 2022 Trevor Gross
 

LICENSE-3rdparty.yml

@@ -22,7 +22,7 @@ pushd "${PROJECT_DIR}" > /dev/null
 
 # Run benchmarks
 message "Running benchmarks"
-cargo bench --workspace --features datadog-crashtracker/benchmarking -- --warm-up-time 1 --measurement-time 5 --sample-size=200
+cargo bench --workspace --features libdd-crashtracker/benchmarking -- --warm-up-time 1 --measurement-time 5 --sample-size=200
 message "Finished running benchmarks"
 
 # Copy the benchmark results to the output directory

benchmark/run_benchmarks_ci.sh

@@ -13,7 +13,7 @@ once_cell = "1.18"
 anyhow = "1.0"
 current_platform = "0.2.0"
 datadog-profiling = { path = "../datadog-profiling" }
-datadog-crashtracker = { path = "../datadog-crashtracker" }
+libdd-crashtracker = { path = "../libdd-crashtracker" }
 libdd-common = { path = "../libdd-common" }
 tempfile = "3.3"
 serde_json = { version = "1.0" }

bin_tests/Cargo.toml

@@ -16,10 +16,10 @@ mod unix {
     use std::env;
     use std::time::Duration;
 
-    use datadog_crashtracker::{
+    use libdd_common::{tag, Endpoint};
+    use libdd_crashtracker::{
         self as crashtracker, CrashtrackerConfiguration, CrashtrackerReceiverConfig, Metadata,
     };
-    use libdd_common::{tag, Endpoint};
 
     const TEST_COLLECTOR_TIMEOUT: Duration = Duration::from_secs(10);
 

bin_tests/src/bin/crashing_test_app.rs

@@ -21,10 +21,10 @@ mod unix {
     use std::path::Path;
     use std::time::Duration;
 
-    use datadog_crashtracker::{
+    use libdd_common::{tag, Endpoint};
+    use libdd_crashtracker::{
         self as crashtracker, CrashtrackerConfiguration, CrashtrackerReceiverConfig, Metadata,
     };
-    use libdd_common::{tag, Endpoint};
 
     const TEST_COLLECTOR_TIMEOUT: Duration = Duration::from_secs(10);