Skip to content

[SNMP] Invert interactive logic in validate mib files #9258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021
Merged

[SNMP] Invert interactive logic in validate mib files #9258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/validate_mib_filenames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@

@click.command(context_settings=CONTEXT_SETTINGS, short_help='Validate MIB file names')
@click.argument('mib_files', nargs=-1)
@click.option('--fix-silent', '-s', is_flag=False, help='Rename all invalid MIB files without prompting to confirm')
@click.option('--interactive', '-i', is_flag=True, help='Prompt to confirm before renaming all invalid MIB files')
@click.pass_context
def validate_mib_filenames(ctx, mib_files, fix_silent):
def validate_mib_filenames(ctx, mib_files, interactive):
"""
Validate MIB file names. Frameworks used to load mib files expect MIB file names to match
MIB name.
Expand Down Expand Up @@ -83,7 +83,7 @@ def validate_mib_filenames(ctx, mib_files, fix_silent):
index += 1

option = '*'
if not fix_silent:
if interactive:
echo_info(
tabulate(
[[mib.index, mib.base_filename, mib.name, mib.is_valid] for mib in mibs],
Expand Down