Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNMP] Invert interactive logic in validate mib files #9258

Merged
merged 1 commit into from
Apr 28, 2021
Merged

[SNMP] Invert interactive logic in validate mib files #9258

merged 1 commit into from
Apr 28, 2021

Conversation

pducolin
Copy link
Contributor

What does this PR do?

Silent execution by default, prompt for user input if explicitly chosen

Motivation

Review of #9228

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@pducolin pducolin requested a review from a team as a code owner April 28, 2021 08:28
@pducolin pducolin merged commit 2c16890 into master Apr 28, 2021
@pducolin pducolin deleted the pducolin/validate-mib-files-improvements branch April 28, 2021 09:06
github-actions bot pushed a commit that referenced this pull request Apr 28, 2021
@pducolin
[snmp] invert interactive logic (#9258) 2c16890
1592237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pducolin @AlexandreYang