Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect version metadata #6556

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Collect version metadata #6556

merged 2 commits into from
Oct 6, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented May 1, 2020

Additional Notes

Blocked on dpkp/kafka-python#2038 (also see dpkp/kafka-python#2024)

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@109ab42). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
...er/datadog_checks/kafka_consumer/kafka_consumer.py 73.93% <100.00%> (ø)
kafka_consumer/tests/test_kafka_consumer.py 97.14% <100.00%> (ø)

@stale
Copy link

stale bot commented May 31, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity.

@stale stale bot added the stale label May 31, 2020
@hithwen
Copy link
Contributor

hithwen commented Jun 1, 2020

dpkp/kafka-python#2038 is merged and dpkp/kafka-python#2024 is closed

@stale stale bot removed the stale label Jun 1, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity.

@stale stale bot added the stale label Jul 3, 2020
@hithwen
Copy link
Contributor

hithwen commented Jul 10, 2020

Linked PR got merged on May 5 2020, waiting for a new release: https://github.com/dpkp/kafka-python/blob/master/CHANGES.md

@stale stale bot removed the stale label Jul 10, 2020
@stale
Copy link

stale bot commented Aug 9, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity.

ChristineTChen
ChristineTChen previously approved these changes Oct 6, 2020
@ofek ofek merged commit 7cded21 into master Oct 6, 2020
@ofek ofek deleted the ofek/kv branch October 6, 2020 21:25
github-actions bot pushed a commit that referenced this pull request Oct 6, 2020
* Collect version metadata

* fix 7cded21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants