Add config specs to active_directory #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hithwen
commented
Feb 17, 2020
ofek
requested changes
Feb 17, 2020
Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
…integrations-core into julia/confspec/active_directory
Codecov Report
|
hithwen
commented
Feb 21, 2020
active_directory/datadog_checks/active_directory/data/conf.yaml.example
Outdated
Show resolved
Hide resolved
hithwen
commented
Feb 21, 2020
|
|
||
| ## @param tags - list of key:value element - optional | ||
| ## List of tags to attach to every metric, event and service check emitted by this integration. | ||
| ## @param tags - list of strings - optional |
There was a problem hiding this comment.
A way to include the key:value on the description?
ofek
requested changes
Feb 21, 2020
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/pdh.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/pdh.yaml
Outdated
Show resolved
Hide resolved
hithwen
commented
Feb 21, 2020
hithwen
commented
Feb 21, 2020
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/pdh.yaml
Show resolved
Hide resolved
hithwen
commented
Feb 27, 2020
active_directory/datadog_checks/active_directory/data/conf.yaml.example
Outdated
Show resolved
Hide resolved
hithwen
commented
Feb 27, 2020
active_directory/datadog_checks/active_directory/data/conf.yaml.example
Outdated
Show resolved
Hide resolved
ofek
requested changes
Mar 19, 2020
| @@ -0,0 +1,59 @@ | |||
| - name: host | |||
| required: false | |||
There was a problem hiding this comment.
Suggested change
| required: false |
| example: . | ||
| type: string | ||
| - name: username | ||
| required: false |
There was a problem hiding this comment.
Suggested change
| required: false |
| value: | ||
| type: string | ||
| - name: additional_metrics | ||
| required: false |
There was a problem hiding this comment.
Suggested change
| required: false |
| value: | ||
| type: string | ||
| - name: password | ||
| required: false |
There was a problem hiding this comment.
Suggested change
| required: false | |
| secret: true |
| items: | ||
| type: string | ||
| - name: counter_data_types | ||
| required: false |
There was a problem hiding this comment.
Suggested change
| required: false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds base pdh specs