-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDM] [Cisco ACI] Use actual int for interface index #18414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmw51798
previously approved these changes
Aug 26, 2024
dkirov-dd
reviewed
Aug 27, 2024
dkirov-dd
previously approved these changes
Aug 27, 2024
Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>
jmw51798
approved these changes
Aug 28, 2024
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Use actual int for interface index * Changelog * Update cisco_aci/datadog_checks/cisco_aci/models.py Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com> --------- Co-authored-by: Jim Wilson <86026167+jmw51798@users.noreply.github.com> Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com> (cherry picked from commit 6915c80)
4 tasks
Kyle-Neale
pushed a commit
that referenced
this pull request
Aug 29, 2024
* Use actual int for interface index * Changelog * Update cisco_aci/datadog_checks/cisco_aci/models.py Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com> --------- Co-authored-by: Jim Wilson <86026167+jmw51798@users.noreply.github.com> Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com> (cherry picked from commit 6915c80) Co-authored-by: zoe ✨ <9274242+zoedt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
QA issue: payload could not be processed because an int was not passed for the interface index
During QA, devices were appearing on the integration check, but not on the NDM page itself - it was successfully creating metadata to send but the service seemed to not be processing it correctly.
Verified in logging from
network-devices-writer
:Getting errors such as:
Motivation
Additional Notes
QA
ddev env start cisco_aci py3.11 --base
on this branchddev env config edit cisco_aci py3.11
ddev env reload cisco_aci py3.11
ddev env agent cisco_aci py3.11 check > output.txt
Check the NDM devices page - check for the devices and the interfaces to appear
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged