Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDM] [Cisco ACI] Use actual int for interface index #18414

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

zoedt
Copy link
Contributor

@zoedt zoedt commented Aug 26, 2024

What does this PR do?

QA issue: payload could not be processed because an int was not passed for the interface index

During QA, devices were appearing on the integration check, but not on the NDM page itself - it was successfully creating metadata to send but the service seemed to not be processing it correctly.

Verified in logging from network-devices-writer:
Getting errors such as:


{
caller | decoder/decoder.go:124
error | error decoding event: error unmarshalling event: cbor: cannot unmarshal UTF-8 text string into Go struct field decoder.structEvent.custom of type int32
level | WARN
ts | 2024-08-23T21:47:49.046857+00:00
}

Motivation

Additional Notes

QA

  1. ddev env start cisco_aci py3.11 --base on this branch
  2. ddev env config edit cisco_aci py3.11
  3. add to the config:
instances:
  - aci_url: https://sandboxapicdc.cisco.com # public sandbox
    username: admin
    pwd: "!v3G@!4@Y" # double quotes are necessary here
    tls_verify: false
    send_ndm_metadata: true
    namespace: your-namespace
  1. ddev env reload cisco_aci py3.11
  2. ddev env agent cisco_aci py3.11 check > output.txt

Check the NDM devices page - check for the devices and the interfaces to appear
image
image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.68%. Comparing base (2b3dc01) to head (4856c38).
Report is 22 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
cisco_aci 94.92% <81.81%> (-0.03%) ⬇️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

jmw51798
jmw51798 previously approved these changes Aug 26, 2024
dkirov-dd
dkirov-dd previously approved these changes Aug 27, 2024
Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>
@jmw51798 jmw51798 dismissed stale reviews from dkirov-dd and themself via 4856c38 August 28, 2024 15:32
@jmw51798 jmw51798 merged commit 6915c80 into master Aug 28, 2024
38 checks passed
@jmw51798 jmw51798 deleted the zoe/interface-evp branch August 28, 2024 15:48
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request Aug 28, 2024
* Use actual int for interface index

* Changelog

* Update cisco_aci/datadog_checks/cisco_aci/models.py

Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>

---------

Co-authored-by: Jim Wilson <86026167+jmw51798@users.noreply.github.com>
Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>
(cherry picked from commit 6915c80)
Kyle-Neale pushed a commit that referenced this pull request Aug 29, 2024
* Use actual int for interface index

* Changelog

* Update cisco_aci/datadog_checks/cisco_aci/models.py

Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>

---------

Co-authored-by: Jim Wilson <86026167+jmw51798@users.noreply.github.com>
Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>
(cherry picked from commit 6915c80)

Co-authored-by: zoe ✨ <9274242+zoedt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants